From: Douglas Anderson <dianders@chromium.org>
To: Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Allen-KH Cheng" <allen-kh.cheng@mediatek.com>,
linux-mediatek@lists.infradead.org,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Hsin-Hsiung Wang" <hsin-hsiung.wang@mediatek.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
wenst@chromium.org, yidilin@chromium.org,
"Tinghan Shen" <tinghan.shen@mediatek.com>,
jwerner@chromium.org, "Weiyi Lu" <weiyi.lu@mediatek.com>,
"Ben Ho" <Ben.Ho@mediatek.com>,
"Seiya Wang" <seiya.wang@mediatek.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Enric Balletbo i Serra" <eballetbo@kernel.org>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek Chromebooks w/ bad FW
Date: Mon, 15 May 2023 13:13:49 -0700 [thread overview]
Message-ID: <20230515131353.v2.cover@dianders> (raw)
As talked about in the bindings patch included in this series
("dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for
Mediatek SoCs w/ broken FW"), many Mediatek-based Chromebooks shipped
with firmware that doesn't properly save/restore some GICR
registers. This causes the system to crash if "pseudo NMIs" are turned
on.
This series makes sure that we never allow turning on "pseudo NMIs" if
we are running with the problematic firmware.
The patches in this series can land in any order and can go through
entirely different trees. None of the patches are harmful on their
own, but to get things fixed we need all of them.
v2 fixes the quirk name and also moves the quirk out of the SoC.dtsi
file and into the Chromebook file. This, unfortunately, means that
mt8186-based Chromebooks are no longer handled since they don't appear
to be upstream yet. :(
Changes in v2:
- "when CPUs are powered" => "when the GIC redistributors are..."
- Changed "Fixes" tag.
- Moved from mt8183.dtsi to mt8183-kukui.dtsi
- Moved from mt8192.dtsi to mt8192-asurada.dtsi
- Moved from mt8195.dtsi to mt8195-cherry.dtsi
- mediatek,gicr-save-quirk => mediatek,broken-save-restore-fw
Douglas Anderson (5):
dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek
SoCs w/ broken FW
irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware
issues
arm64: dts: mediatek: mt8183: Add mediatek,broken-save-restore-fw to
kukui
arm64: dts: mediatek: mt8192: Add mediatek,broken-save-restore-fw to
asurada
arm64: dts: mediatek: mt8195: Add mediatek,broken-save-restore-fw to
cherry
.../interrupt-controller/arm,gic-v3.yaml | 6 ++++++
.../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
.../boot/dts/mediatek/mt8192-asurada.dtsi | 4 ++++
.../boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
drivers/irqchip/irq-gic-common.c | 8 ++++++--
drivers/irqchip/irq-gic-common.h | 1 +
drivers/irqchip/irq-gic-v3.c | 20 +++++++++++++++++++
7 files changed, 45 insertions(+), 2 deletions(-)
--
2.40.1.606.ga4b1b128d6-goog
next reply other threads:[~2023-05-15 20:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 20:13 Douglas Anderson [this message]
2023-05-15 20:13 ` [PATCH v2 1/5] dt-bindings: interrupt-controller: arm,gic-v3: Add quirk for Mediatek SoCs w/ broken FW Douglas Anderson
2023-05-16 13:24 ` AngeloGioacchino Del Regno
2023-05-15 20:13 ` [PATCH v2 2/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Douglas Anderson
2023-05-16 13:23 ` AngeloGioacchino Del Regno
2023-05-16 14:19 ` Doug Anderson
2023-05-16 14:57 ` Marc Zyngier
2023-05-30 8:29 ` Geert Uytterhoeven
2023-05-30 9:46 ` Marc Zyngier
2023-05-30 9:58 ` Geert Uytterhoeven
2023-05-30 16:36 ` Doug Anderson
2023-05-15 20:13 ` [PATCH v2 3/5] arm64: dts: mediatek: mt8183: Add mediatek,broken-save-restore-fw to kukui Douglas Anderson
2023-05-16 13:18 ` AngeloGioacchino Del Regno
2023-05-15 20:13 ` [PATCH v2 4/5] arm64: dts: mediatek: mt8192: Add mediatek,broken-save-restore-fw to asurada Douglas Anderson
2023-05-16 13:18 ` AngeloGioacchino Del Regno
2023-05-15 20:13 ` [PATCH v2 5/5] arm64: dts: mediatek: mt8195: Add mediatek,broken-save-restore-fw to cherry Douglas Anderson
2023-05-16 13:18 ` AngeloGioacchino Del Regno
2023-05-16 9:58 ` [PATCH v2 0/5] irqchip/gic-v3: Disable pseudo NMIs on Mediatek Chromebooks w/ bad FW Marc Zyngier
2023-05-29 15:41 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515131353.v2.cover@dianders \
--to=dianders@chromium.org \
--cc=Ben.Ho@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=jwerner@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=tglx@linutronix.de \
--cc=tinghan.shen@mediatek.com \
--cc=weiyi.lu@mediatek.com \
--cc=wenst@chromium.org \
--cc=yidilin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).