[PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node

[PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node

[Marek Vasut]

Add DT node for the DeWarp Engine of the i.MX8MP.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 245c560674de7..b64c944eecf82 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1534,6 +1534,16 @@ isi_in_1: endpoint {
 				};
 			};
 
+			dewarp: dwe@32e30000 {
+				compatible = "nxp,imx8mp-dw100";
+				reg = <0x32e30000 0x10000>;
+				interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
+					 <&clk IMX8MP_CLK_MEDIA_APB_ROOT>;
+				clock-names = "axi", "ahb";
+				power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_DWE>;
+			};
+
 			mipi_csi_0: csi@32e40000 {
 				compatible = "fsl,imx8mp-mipi-csi2", "fsl,imx8mm-mipi-csi2";
 				reg = <0x32e40000 0x10000>;
-- 
2.39.2

Re: [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node

[Alexander Stein]

Hi Marek,

Am Montag, 15. Mai 2023, 18:32:24 CEST schrieb Marek Vasut:
> Add DT node for the DeWarp Engine of the i.MX8MP.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org

While the node itself is okay, could you please add a patch for reordering the 
other nodes in aips4 before adding dewarp? dwe@32e30000 should be at the top 
after ISI (ISP not yet added).

Best regards,
Alexander

> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> 245c560674de7..b64c944eecf82 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1534,6 +1534,16 @@ isi_in_1: endpoint {
>  				};
>  			};
> 
> +			dewarp: dwe@32e30000 {
> +				compatible = "nxp,imx8mp-dw100";
> +				reg = <0x32e30000 0x10000>;
> +				interrupts = <GIC_SPI 100 
IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk 
IMX8MP_CLK_MEDIA_AXI_ROOT>,
> +					 <&clk 
IMX8MP_CLK_MEDIA_APB_ROOT>;
> +				clock-names = "axi", "ahb";
> +				power-domains = <&media_blk_ctrl 
IMX8MP_MEDIABLK_PD_DWE>;
> +			};
> +
>  			mipi_csi_0: csi@32e40000 {
>  				compatible = "fsl,imx8mp-mipi-csi2", 
"fsl,imx8mm-mipi-csi2";
>  				reg = <0x32e40000 0x10000>;


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node

[Marek Vasut]

On 5/16/23 08:38, Alexander Stein wrote:
> Hi Marek,

Hi,

> Am Montag, 15. Mai 2023, 18:32:24 CEST schrieb Marek Vasut:
>> Add DT node for the DeWarp Engine of the i.MX8MP.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Richard Cochran <richardcochran@gmail.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
> 
> While the node itself is okay, could you please add a patch for reordering the
> other nodes in aips4 before adding dewarp? dwe@32e30000 should be at the top
> after ISI (ISP not yet added).

The sorting of nodes does not conflict with this change, so I'll send a 
separate patch for that.

Re: [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node

[Marek Vasut]

On 5/16/23 10:06, Marek Vasut wrote:
> On 5/16/23 08:38, Alexander Stein wrote:
>> Hi Marek,
> 
> Hi,
> 
>> Am Montag, 15. Mai 2023, 18:32:24 CEST schrieb Marek Vasut:
>>> Add DT node for the DeWarp Engine of the i.MX8MP.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> ---
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> Cc: Richard Cochran <richardcochran@gmail.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: linux-arm-kernel@lists.infradead.org
>>
>> While the node itself is okay, could you please add a patch for 
>> reordering the
>> other nodes in aips4 before adding dewarp? dwe@32e30000 should be at 
>> the top
>> after ISI (ISP not yet added).
> 
> The sorting of nodes does not conflict with this change, so I'll send a 
> separate patch for that.

Well that wasn't as easy as I thought, but oh well, V2 is out.