From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org,
bhupesh.linux@gmail.com, bhupesh.sharma@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org
Subject: [PATCH v5 5/5] arm64: dts: qcom: qrb4210-rb2: Enable EUD debug peripheral
Date: Wed, 17 May 2023 03:03:08 +0530 [thread overview]
Message-ID: <20230516213308.2432018-6-bhupesh.sharma@linaro.org> (raw)
In-Reply-To: <20230516213308.2432018-1-bhupesh.sharma@linaro.org>
Since the USB-C type port on the Qualcomm QRB4210-RB2 board
can be set primarily in a 'device' configuration (with the default
DIP switch settings), it makes sense to enable the EUD debug
peripheral on the board by default by setting the USB 'dr_mode' property
as 'otg'.
Now, the EUD debug peripheral can be enabled by executing:
$ echo 1 > /sys/bus/platform/drivers/qcom_eud/1610000.eud/enable
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 27 +++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index 1a0776a0cfd0..0ce72f1ebc10 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -30,6 +30,10 @@ vph_pwr: vph-pwr-regulator {
};
};
+&eud {
+ status = "okay";
+};
+
&qupv3_id_0 {
status = "okay";
};
@@ -253,7 +257,28 @@ &usb {
&usb_dwc3 {
maximum-speed = "super-speed";
- dr_mode = "peripheral";
+
+ /*
+ * There is only one USB DWC3 controller on QRB4210 board and it is connected
+ * via a DIP Switch:
+ * - to either an USB - C type connector or an USB - A type connector
+ * (via a GL3590-S hub), and
+ * - to either an USB - A type connector (via a GL3590-S hub) or a connector
+ * for further connection with a mezzanine board.
+ *
+ * All of the above hardware muxes would allow us to hook things up in
+ * different ways to some potential benefit for static configurations (for e.g.
+ * on one hand we can have two USB - A type connectors and a USB - Ethernet
+ * connection available and on the other we can use the USB - C type in
+ * peripheral mode).
+ *
+ * Note that since the USB - C type can be used only in peripehral mode,
+ * so hardcoding the mode to 'peripheral' here makes sense.
+ *
+ * However since we want to use the EUD debug device, we set the mode as
+ * 'otg' here.
+ */
+ dr_mode = "otg";
};
&usb_hsphy {
--
2.38.1
prev parent reply other threads:[~2023-05-16 21:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 21:33 [PATCH v5 0/5] Add Qualcomm SM6115 / SM4250 EUD dt-bindings & driver support Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 1/5] usb: misc: eud: Fix eud sysfs path (use 'qcom_eud') Bhupesh Sharma
2023-05-17 5:38 ` Manivannan Sadhasivam
2023-05-17 6:28 ` Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 2/5] dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support Bhupesh Sharma
2023-05-17 14:55 ` Krzysztof Kozlowski
2023-05-16 21:33 ` [PATCH v5 3/5] usb: misc: eud: Add driver support for SM6115 / SM4250 Bhupesh Sharma
2023-05-17 4:50 ` Greg KH
2023-05-17 6:33 ` Bhupesh Sharma
2023-05-16 21:33 ` [PATCH v5 4/5] arm64: dts: qcom: sm6115: Add EUD dt node and dwc3 connector Bhupesh Sharma
2023-05-16 21:33 ` Bhupesh Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516213308.2432018-6-bhupesh.sharma@linaro.org \
--to=bhupesh.sharma@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).