Re: [PATCH 1/2] dt-bindings: clock: Add binding documentation for TI Audio REFCLK

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

On Wed, May 17, 2023 at 01:04:05PM +0530, Jai Luthra wrote:
> Add DT bindings for TI's audio reference clocks (REFCLK) present on AM62
> SoC.

This seems fine to me. Perhaps Krzysztof will differ...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> 
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---
>  .../bindings/clock/ti,am62-audio-refclk.yaml       | 44 ++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml b/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
> new file mode 100644
> index 000000000000..7c4cf7abe007
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti,am62-audio-refclk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI Audio Reference Clock
> +
> +maintainers:
> +  - Jai Luthra <j-luthra@ti.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: ti,am62-audio-refclk
> +      - const: syscon
> +
> +  "#clock-cells":
> +    const: 0
> +
> +  reg:
> +    maxItems: 1

Just a minor comment, usually reg appears after compatible and before
anything else.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]