From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9609EC77B7D for ; Wed, 17 May 2023 05:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232537AbjEQF5t (ORCPT ); Wed, 17 May 2023 01:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjEQF5t (ORCPT ); Wed, 17 May 2023 01:57:49 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE5BC26B5; Tue, 16 May 2023 22:57:47 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34H4lrXV010111; Wed, 17 May 2023 05:57:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=f8LRxXaxNUlwWF63UqhPupBQMhZCC08DgDyWOVIf1Qg=; b=BE9XqsHsWcLuTDuJeWE/h2AZ0Dqp1RHzm1uQOIyshc4SELb/aNvQWOMyzzFMVHZP6jMI iALUd4F4ImYE4BiX2jxK/1KPr4kpZI1dJcX3vw3NPi0JE+yHI7sTSjE+/JyIYDCqpMPa 2KkB+W+5eCRXvocIXJlaBlV8si5XWXfmJylyLk6LPxOHGrCaPcD1A7I49HS61BX+0ArI mxAb/wXlxdevRWY71d4p7kC40AXWsSUPzBQPk8/SkDRKzUVKeCITeuuHBeQI0TGMbedo fAJ8MurmnY9KTIYBn15nuiGV36Vl4H6cjD6gj3jegjh58wtqpx96Ji+76Mq5Lokic3pD YA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qme0m96yp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 05:57:42 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34H5vfVA015386 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 05:57:42 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 16 May 2023 22:57:37 -0700 Date: Wed, 17 May 2023 11:27:27 +0530 From: Varadarajan Narayanan To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , Praveenkumar I Subject: Re: [PATCH v3 2/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Message-ID: <20230517055726.GA3165@varda-linux.qualcomm.com> References: <37adcf5d8d545a076e8ed971a4fb6c6c2833ef3c.1684140883.git.quic_varada@quicinc.com> <20230516120426.GA1679@varda-linux.qualcomm.com> <1999753b-ceee-d66c-9a48-cbcbb8e6236e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1999753b-ceee-d66c-9a48-cbcbb8e6236e@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: U9OdrTpRtgKX8rTGV_CPYWammzoH6ioF X-Proofpoint-ORIG-GUID: U9OdrTpRtgKX8rTGV_CPYWammzoH6ioF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305170050 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 16, 2023 at 03:06:40PM +0200, Krzysztof Kozlowski wrote: > On 16/05/2023 14:04, Varadarajan Narayanan wrote: > > On Mon, May 15, 2023 at 06:10:29PM +0200, Krzysztof Kozlowski wrote: > >> On 15/05/2023 12:13, Varadarajan Narayanan wrote: > >>> From: Praveenkumar I > >>> > >>> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > >>> > >>> Signed-off-by: Praveenkumar I > >>> Signed-off-by: Varadarajan Narayanan > >>> --- > >>> [v3]: > >>> Fix dt_binding_check & dtbs_check errors (Used > >>> Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > >>> as reference/example) > >>> > >>> Drop 'Acked-by: Rob Herring' as suggested in review > >>> > >>> [v2]: > >>> Thanks to Krzysztof Kozlowski > >>> for the tip to make qcom,ipq8074-tsens as fallback. > >>> --- > >>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 13 +++++++++++-- > >>> 1 file changed, 11 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>> index d9aa54c..57e3908 100644 > >>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > >>> @@ -19,6 +19,11 @@ description: | > >>> properties: > >>> compatible: > >>> oneOf: > >>> + - const: qcom,tsens-v0_1 > >>> + - const: qcom,tsens-v1 > >>> + - const: qcom,tsens-v2 > >> > >> Nope, these are not correct. > >> > >>> + - const: qcom,ipq8074-tsens > >> > >> Also nope, this is already there. > >> > >>> + > >>> - description: msm8960 TSENS based > >>> items: > >>> - enum: > >>> @@ -66,8 +71,10 @@ properties: > >>> - const: qcom,tsens-v2 > >>> > >>> - description: v2 of TSENS with combined interrupt > >>> - enum: > >>> - - qcom,ipq8074-tsens > >> > >> Why? > >> > >>> + items: > >>> + - enum: > >>> + - qcom,ipq9574-tsens > >>> + - const: qcom,ipq8074-tsens > > > > Without changing it like this either dtbs_check or > > dt_binding_check kept failing. > > > > - description: v2 of TSENS with combined interrupt > > enum: > > - qcom,ipq8074-tsens > > - qcom,ipq9574-tsens > > But we do not talk about this... Look, I commented out under specific > hunks which are not correct. Not under the hunk which is correct. > > > > > dtbs_check gave this kind of error > > ['qcom,ipq9574-tsens', 'qcom,ipq8074-tsens'] is too long > > > > After changing it like in https://elixir.bootlin.com/linux/v6.3-rc6/source/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml#L31 > > > > - description: v2 of TSENS with combined interrupt > > const: qcom,ipq8074-tsens > > - enum: > > - qcom,ipq9574-tsens > > - const: qcom,ipq8074-tsens > > > > dt_binding_check gives the following error > > > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:70:9: did not find expected key > > Because it is not even valid syntax. > > > > > and dtbs_check gives > > > > ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:70:9: [error] syntax error: expected , but found '-' (syntax) > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > ./Documentation/devicetree/bindings/clock/qcom,gcc-ipq8064.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml > > ./Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/thermal/qcom-tsens.yaml > > ./Documentation/devicetree/bindings/thermal/qcom-tsens.yaml:70:9: did not find expected key > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > /local/mnt/workspace/varada/v3/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml: ignoring, error parsing file > > > > If i change it like below, > > > > - description: v2 of TSENS with combined interrupt > > enum: > > - qcom,ipq9574-tsens > > - const: qcom,ipq8074-tsens > > > > dt_binding_check and dtbs_check gives same error as above. > > > > Looked around and found Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > > which seemed to do something similar to what is wanted in this > > case. Hence changed qcom-tsens.yaml similar to the allwinner yaml > > file. After which dt_binding_check and dtbs_check passed. Please > > let me know if there is a better way to solve this. Will go with > > Changing one valid syntax to another valid syntax is not related to the > patch. If you think such change as reasonable, please split it, but to > me it does not look justified. As for actual change, so adding new > compatible, it's not really related to the others. Why you cannot add > the proper list (so the only valid hunk) and that's it? Not sure if I didn't express properly. There are two parts to this patch. Part-1 is adding the 'const' entries at the beginning i.e. + - const: qcom,tsens-v0_1 + - const: qcom,tsens-v1 + - const: qcom,tsens-v2 + - const: qcom,ipq8074-tsens Part-2 is changing from one valid syntax to another i.e. + items: + - enum: + - qcom,ipq9574-tsens + - const: qcom,ipq8074-tsens Without both of the above changes, either or both of dtbs_check & dt_binding_check fails. So, it is not possible to just add the "valid hunk" (part-2) alone. If having both part-1 and part-2 in the same patch is not acceptable, shall I split them into two patches? Please let me know. Thanks Varada