* [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
@ 2023-05-18 8:47 haibo.chen
2023-05-18 12:10 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: haibo.chen @ 2023-05-18 8:47 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, devicetree, haibo.chen
From: Haibo Chen <haibo.chen@nxp.com>
On imx6sll-evk board, eMMC is connect on the usdhc2.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
arch/arm/boot/dts/imx6sll-evk.dts | 67 +++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index 269092ac881c..a83c133717b9 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -109,6 +109,14 @@ reg_sd1_vmmc: regulator-sd1-vmmc {
enable-active-high;
};
+ reg_sd2_vmmc: regulator-sd2-vmmc {
+ compatible = "regulator-fixed";
+ regulator-name = "eMMC-VCCQ";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ };
+
reg_sd3_vmmc: regulator-sd3-vmmc {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -343,6 +351,17 @@ &usdhc1 {
status = "okay";
};
+&usdhc2 {
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
+ pinctrl-0 = <&pinctrl_usdhc2>;
+ pinctrl-1 = <&pinctrl_usdhc2_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
+ bus-width = <8>;
+ non-removable;
+ vqmmc-supply = <®_sd2_vmmc>;
+ status = "okay";
+};
+
&usbotg1 {
vbus-supply = <®_usb_otg1_vbus>;
pinctrl-names = "default";
@@ -466,6 +485,54 @@ MX6SLL_PAD_SD1_DATA3__SD1_DATA3 0x170f9
>;
};
+ pinctrl_usdhc2: usdhc2grp {
+ fsl,pins = <
+ MX6SLL_PAD_SD2_CMD__SD2_CMD 0x17059
+ MX6SLL_PAD_SD2_CLK__SD2_CLK 0x13059
+ MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x17059
+ MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x17059
+ MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x17059
+ MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x17059
+ MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x17059
+ MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x17059
+ MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x17059
+ MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x17059
+ MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x13059
+ >;
+ };
+
+ pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
+ fsl,pins = <
+ MX6SLL_PAD_SD2_CMD__SD2_CMD 0x170b9
+ MX6SLL_PAD_SD2_CLK__SD2_CLK 0x130b9
+ MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x170b9
+ MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x170b9
+ MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x170b9
+ MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x170b9
+ MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x170b9
+ MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x170b9
+ MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x170b9
+ MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x170b9
+ MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x130b9
+ >;
+ };
+
+ pinctrl_usdhc2_200mhz: usdhc2grp_200mhz {
+ fsl,pins = <
+ MX6SLL_PAD_SD2_CMD__SD2_CMD 0x170f9
+ MX6SLL_PAD_SD2_CLK__SD2_CLK 0x130f9
+ MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x170f9
+ MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x170f9
+ MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x170f9
+ MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x170f9
+ MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x170f9
+ MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x170f9
+ MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x170f9
+ MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x170f9
+ MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x130f9
+ >;
+ };
+
pinctrl_usbotg1: usbotg1grp {
fsl,pins = <
MX6SLL_PAD_EPDC_PWR_COM__USB_OTG1_ID 0x17059
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
2023-05-18 8:47 [PATCH] ARM: dts: imx6sll-evk: add eMMC node support haibo.chen
@ 2023-05-18 12:10 ` Krzysztof Kozlowski
2023-05-19 6:07 ` Bough Chen
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-18 12:10 UTC (permalink / raw)
To: haibo.chen, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo,
s.hauer
Cc: kernel, festevam, linux-imx, devicetree
On 18/05/2023 10:47, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> On imx6sll-evk board, eMMC is connect on the usdhc2.
> + pinctrl_usdhc2: usdhc2grp {
> + fsl,pins = <
> + MX6SLL_PAD_SD2_CMD__SD2_CMD 0x17059
> + MX6SLL_PAD_SD2_CLK__SD2_CLK 0x13059
> + MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x17059
> + MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x17059
> + MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x17059
> + MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x17059
> + MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x17059
> + MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x17059
> + MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x17059
> + MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x17059
> + MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x13059
> + >;
> + };
> +
> + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
No underscores in node names. Schema expects certain pattern, so be sure
to test it. Please run `make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
2023-05-18 12:10 ` Krzysztof Kozlowski
@ 2023-05-19 6:07 ` Bough Chen
2023-05-30 10:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Bough Chen @ 2023-05-19 6:07 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
devicetree@vger.kernel.org
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 2023年5月18日 20:10
> To: Bough Chen <haibo.chen@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
> <linux-imx@nxp.com>; devicetree@vger.kernel.org
> Subject: Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
>
> On 18/05/2023 10:47, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > On imx6sll-evk board, eMMC is connect on the usdhc2.
>
>
> > + pinctrl_usdhc2: usdhc2grp {
> > + fsl,pins = <
> > + MX6SLL_PAD_SD2_CMD__SD2_CMD 0x17059
> > + MX6SLL_PAD_SD2_CLK__SD2_CLK 0x13059
> > + MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x17059
> > + MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x17059
> > + MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x17059
> > + MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x17059
> > + MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x17059
> > + MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x17059
> > + MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x17059
> > + MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x17059
> > + MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x13059
> > + >;
> > + };
> > +
> > + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
>
> No underscores in node names. Schema expects certain pattern, so be sure to
> test it. Please run `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
Hi Krzvsztof,
Thanks for point that out. I will change this.
But when I use 'make dtbs_check' to check the imx6sll-evk.dtb, though there is some issue shows up, but do not find any message point the rules "no underscores in node names".
Anything I missing? Or this is just an implied rule？
$ makez dtbs_check [159/1961]
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTLD scripts/dtc/dtc
HOSTCC scripts/dtc/libfdt/fdt.o
HOSTCC scripts/dtc/libfdt/fdt_ro.o
HOSTCC scripts/dtc/libfdt/fdt_wip.o
HOSTCC scripts/dtc/libfdt/fdt_sw.o
HOSTCC scripts/dtc/libfdt/fdt_rw.o
HOSTCC scripts/dtc/libfdt/fdt_strerror.o
HOSTCC scripts/dtc/libfdt/fdt_empty_tree.o
HOSTCC scripts/dtc/libfdt/fdt_addresses.o
HOSTCC scripts/dtc/libfdt/fdt_overlay.o
HOSTCC scripts/dtc/fdtoverlay.o
HOSTLD scripts/dtc/fdtoverlay
LINT Documentation/devicetree/bindings
./Documentation/devicetree/bindings/arm/fsl.yaml:930:46: [error] syntax error: found character '\t' that cannot start any token (syntax)
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
UPD include/config/kernel.release
DTC_CHK arch/arm/boot/dts/imx6sll-evk.dtb
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: spdif@2004000: compatible:0: 'fsl,imx6sl-spdif' is not one of ['fsl,imx35-spdif', 'fsl,vf610-spdif', 'fsl,imx6sx-spdi
f', 'fsl,imx8qm-spdif', 'fsl,imx8qxp-spdif', 'fsl,imx8mq-spdif', 'fsl,imx8mm-spdif', 'fsl,imx8mn-spdif', 'fsl,imx8ulp-spdif']
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: spdif@2004000: compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif'] is too long
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: spdif@2004000: clock-names:9: 'spba' was expected
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/spdif@2004000: failed to match any schema with compatible: ['fsl,imx6sl-spdif', 'fsl,imx35-spdif']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/ssi@2028000: failed to match any schema with compatible: ['fsl,imx6sl-ssi', 'fsl,imx51-ssi']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/ssi@2028000: failed to match any schema with compatible: ['fsl,imx6sl-ssi', 'fsl,imx51-ssi']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/ssi@202c000: failed to match any schema with compatible: ['fsl,imx6sl-ssi', 'fsl,imx51-ssi']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/ssi@202c000: failed to match any schema with compatible: ['fsl,imx6sl-ssi', 'fsl,imx51-ssi']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/ssi@2030000: failed to match any schema with compatible: ['fsl,imx6sl-ssi', 'fsl,imx51-ssi']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/spba-bus@2000000/ssi@2030000: failed to match any schema with compatible: ['fsl,imx6sl-ssi', 'fsl,imx51-ssi']
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: serial@2034000: dma-name: b'rx\x00tx\x00' is not of type 'object', 'array', 'boolean', 'null'
From schema: /home/nxa12937/dt-schema/dtschema/schemas/dt-core.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: timer@2098000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sl-gpt'] is too short [110/1961]
'fsl,imx1-gpt' was expected
'fsl,imx21-gpt' was expected
'fsl,imx27-gpt' was expected
'fsl,imx31-gpt' was expected
'fsl,imx6sl-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt', 'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
'fsl,imx6dl-gpt' was expected
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/anatop@20c8000: failed to match any schema with compatible: ['fsl,imx6sll-anatop', 'fsl,imx6q-anatop', 'syscon', 'simple-mfd']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/anatop@20c8000: failed to match any schema with compatible: ['fsl,imx6sll-anatop', 'fsl,imx6q-anatop', 'syscon', 'simple-mfd']
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: regulator-3p0@20c8120: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/regulator/anatop-regulator.yaml
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/usb-phy@20c9000: failed to match any schema with compatible: ['fsl,imx6sll-usbphy', 'fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/usb-phy@20c9000: failed to match any schema with compatible: ['fsl,imx6sll-usbphy', 'fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/usb-phy@20c9000: failed to match any schema with compatible: ['fsl,imx6sll-usbphy', 'fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/usb-phy@20ca000: failed to match any schema with compatible: ['fsl,imx6sll-usbphy', 'fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/usb-phy@20ca000: failed to match any schema with compatible: ['fsl,imx6sll-usbphy', 'fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/usb-phy@20ca000: failed to match any schema with compatible: ['fsl,imx6sll-usbphy', 'fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: interrupt-controller@20dc000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-gpc', 'fsl,imx6q-gpc'] is too long
'fsl,imx6sll-gpc' is not one of ['fsl,imx6q-gpc']
'fsl,imx6sll-gpc' is not one of ['fsl,imx6qp-gpc', 'fsl,imx6sl-gpc', 'fsl,imx6sx-gpc', 'fsl,imx6ul-gpc']
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: interrupt-controller@20dc000: 'clocks' is a required property
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: interrupt-controller@20dc000: 'clock-names' is a required property
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: interrupt-controller@20dc000: 'pgc' is a required property
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/interrupt-controller@20dc000: failed to match any schema with compatible: ['fsl,imx6sll-gpc', 'fsl,imx6q-gpc']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/pinctrl@20e0000: failed to match any schema with compatible: ['fsl,imx6sll-iomuxc']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/iomuxc-gpr@20e4000: failed to match any schema with compatible: ['fsl,imx6sll-iomuxc-gpr', 'fsl,imx6q-iomuxc-gpr', 'syscon']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/iomuxc-gpr@20e4000: failed to match any schema with compatible: ['fsl,imx6sll-iomuxc-gpr', 'fsl,imx6q-iomuxc-gpr', 'syscon']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /soc/bus@2000000/csi@20e8000: failed to match any schema with compatible: ['fsl,imx6sll-csi', 'fsl,imx6s-csi']
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: lcd-controller@20f8000: compatible: 'oneOf' conditional failed, one must be fixed:
['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
'fsl,imx6sll-lcdif' is not one of ['fsl,imx23-lcdif', 'fsl,imx28-lcdif', 'fsl,imx6sx-lcdif', 'fsl,imx8mp-lcdif']
'fsl,imx6sx-lcdif' was expected
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: lcd-controller@20f8000: clocks: [[2, 129], [2, 123], [2, 0]] is too long
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: lcd-controller@20f8000: clock-names: ['pix', 'axi', 'disp_axi'] is too long
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
/home/nxa12937/linux-next2/linux-next/arch/arm/boot/dts/imx6sll-evk.dtb: backlight-display: 'power-supply' is a required property
From schema: /home/nxa12937/linux-next2/linux-next/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /sound: failed to match any schema with compatible: ['fsl,imx6sl-evk-wm8962', 'fsl,imx-audio-wm8962']
arch/arm/boot/dts/imx6sll-evk.dtb:0:0: /sound: failed to match any schema with compatible: ['fsl,imx6sl-evk-wm8962', 'fsl,imx-audio-wm8962']
Best Regards
Haibo Chen
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
2023-05-19 6:07 ` Bough Chen
@ 2023-05-30 10:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 10:39 UTC (permalink / raw)
To: Bough Chen, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
devicetree@vger.kernel.org
On 19/05/2023 08:07, Bough Chen wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: 2023年5月18日 20:10
>> To: Bough Chen <haibo.chen@nxp.com>; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
>> shawnguo@kernel.org; s.hauer@pengutronix.de
>> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx
>> <linux-imx@nxp.com>; devicetree@vger.kernel.org
>> Subject: Re: [PATCH] ARM: dts: imx6sll-evk: add eMMC node support
>>
>> On 18/05/2023 10:47, haibo.chen@nxp.com wrote:
>>> From: Haibo Chen <haibo.chen@nxp.com>
>>>
>>> On imx6sll-evk board, eMMC is connect on the usdhc2.
>>
>>
>>> + pinctrl_usdhc2: usdhc2grp {
>>> + fsl,pins = <
>>> + MX6SLL_PAD_SD2_CMD__SD2_CMD 0x17059
>>> + MX6SLL_PAD_SD2_CLK__SD2_CLK 0x13059
>>> + MX6SLL_PAD_SD2_DATA0__SD2_DATA0 0x17059
>>> + MX6SLL_PAD_SD2_DATA1__SD2_DATA1 0x17059
>>> + MX6SLL_PAD_SD2_DATA2__SD2_DATA2 0x17059
>>> + MX6SLL_PAD_SD2_DATA3__SD2_DATA3 0x17059
>>> + MX6SLL_PAD_SD2_DATA4__SD2_DATA4 0x17059
>>> + MX6SLL_PAD_SD2_DATA5__SD2_DATA5 0x17059
>>> + MX6SLL_PAD_SD2_DATA6__SD2_DATA6 0x17059
>>> + MX6SLL_PAD_SD2_DATA7__SD2_DATA7 0x17059
>>> + MX6SLL_PAD_GPIO4_IO21__SD2_STROBE 0x13059
>>> + >;
>>> + };
>>> +
>>> + pinctrl_usdhc2_100mhz: usdhc2grp_100mhz {
>>
>> No underscores in node names. Schema expects certain pattern, so be sure to
>> test it. Please run `make dtbs_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> Hi Krzvsztof,
>
> Thanks for point that out. I will change this.
> But when I use 'make dtbs_check' to check the imx6sll-evk.dtb, though there is some issue shows up, but do not find any message point the rules "no underscores in node names".
> Anything I missing? Or this is just an implied rule？
underscores is explicit. dtc (make dtbs) with W=2 already complains
about it.
Maybe your bindings for pinctrl were not converted to DT schema? But in
such case anyway we want the same pattern for this as for other iMX schemas.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-30 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-18 8:47 [PATCH] ARM: dts: imx6sll-evk: add eMMC node support haibo.chen
2023-05-18 12:10 ` Krzysztof Kozlowski
2023-05-19 6:07 ` Bough Chen
2023-05-30 10:39 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).