From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602C2C7EE22 for ; Thu, 18 May 2023 13:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbjERNa6 (ORCPT ); Thu, 18 May 2023 09:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231164AbjERNa6 (ORCPT ); Thu, 18 May 2023 09:30:58 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AB881A2; Thu, 18 May 2023 06:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fRqoAfEGrb69vxhTSyLB10x+JE5MQ4XwObAsHGXg2dw=; b=QT8cOkj6ZnwlK7KEFGou1i0Ims a/OgxDUpB5KbydZR+HtiBc1t8bql/2eVlQ11ToWwMVibuBWJuOZz7IxC5jJ+6kZdkEyoGu3kIwOdc wkKTzz3e4KrRVVQgo32dSpon6qaQcpPaMNyEKD65h0het0ZopPO8/72W31hn0FGrVnRY=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:55638 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1pzdiT-0004VO-SJ; Thu, 18 May 2023 09:30:50 -0400 Date: Thu, 18 May 2023 09:30:49 -0400 From: Hugo Villeneuve To: Conor Dooley Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-gpio@vger.kernel.org, Hugo Villeneuve , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20230518093049.1e1cdf9561ea326f4655af02@hugovil.com> In-Reply-To: <20230517-argue-unbeaten-b07405fdd313@spud> References: <20230517150746.3823249-1-hugo@hugovil.com> <20230517-argue-unbeaten-b07405fdd313@spud> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH 1/2] dt-bindings: sc16is7xx: Add property to change GPIO function X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 17 May 2023 18:25:07 +0100 Conor Dooley wrote: > On Wed, May 17, 2023 at 11:07:46AM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > > > Some variants in this series of uart controllers have GPIO pins that > > are shared between GPIO and modem control lines. > > > > The pin mux mode (GPIO or modem control lines) can be set for each > > ports (channels) supported by the variant. > > > > This adds a property to the device tree to set the GPIO pin mux to > > modem control lines on selected ports if needed. > > > > Signed-off-by: Hugo Villeneuve > > --- > > .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > index 0fa8e3e43bf8..426b7285ad50 100644 > > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > @@ -23,6 +23,9 @@ Optional properties: > > 1 = active low. > > - irda-mode-ports: An array that lists the indices of the port that > > should operate in IrDA mode. > > +- modem-control-line-ports: An array that lists the indices of the port that > > + should have shared GPIO lines configured as modem > > + control lines. > > If this is an NXP specific property, should it not have an nxp, vendor > prefix? Yes, I will resubmit a V2 with nxp vendor prefix. Hugo.