From: Conor Dooley <conor@kernel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, bhelgaas@google.com,
lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org,
bharat.kumar.gogada@amd.com, michals@amd.com,
nagaradhesh.yeleswarapu@amd.com
Subject: Re: [PATCH v3 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge
Date: Fri, 19 May 2023 20:13:44 +0100 [thread overview]
Message-ID: <20230519-decidable-prelude-2f0d58041f02@spud> (raw)
In-Reply-To: <20230519105901.2399452-3-thippeswamy.havalige@amd.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Fri, May 19, 2023 at 04:29:00PM +0530, Thippeswamy Havalige wrote:
> Add YAML dtschemas of Xilinx XDMA Soft IP PCIe Root Port Bridge
> dt binding.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
Looks like you might've forgotten a Co-developed-by?
> diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> +properties:
> + compatible:
> + const: xlnx,xdma-host-3.00
Perhaps not a question for you Thippeswamy, but is there a reason for
PCI root ports not having any soc-specific compatibles? Rob (if you see
this when you're back)?
> + interrupt-controller ;
Looks like you didn't see Michal's comment about the extra space.
If you resubmit for some other reason, you should fix that in the
process :)
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-19 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 10:58 [PATCH v3 0/3] Add support for Xilinx XDMA Soft IP as Root Port Thippeswamy Havalige
2023-05-19 10:58 ` [PATCH v3 1/3] Move and rename error interrupt bits to a common header Thippeswamy Havalige
2023-05-19 10:59 ` [PATCH v3 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge Thippeswamy Havalige
2023-05-19 19:13 ` Conor Dooley [this message]
2023-05-31 6:59 ` Havalige, Thippeswamy
2023-05-19 10:59 ` [PATCH v3 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver Thippeswamy Havalige
2023-05-26 5:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519-decidable-prelude-2f0d58041f02@spud \
--to=conor@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michals@amd.com \
--cc=nagaradhesh.yeleswarapu@amd.com \
--cc=robh+dt@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).