Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, marex@denx.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v4 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
Date: Fri, 19 May 2023 20:23:07 +0100	[thread overview]
Message-ID: <20230519-floral-diagram-894858b940c1@spud> (raw)
In-Reply-To: <20230519125236.352050-2-festevam@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Hey Fabio,

On Fri, May 19, 2023 at 09:52:34AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The i.MX6SX General Purpose Registers is a set of register that serves
> various different purposes and in particular, IOMUXC_GPR_GPR6, at
> offset 0x18, can be used to configure the LDB block.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> +  bridge@18:
> +    type: object
> +    $ref: /schemas/display/bridge/fsl,ldb.yaml#
> +    unevaluatedProperties: false

How come you need to upgrade the additionaProperties: false, and the
"plain old" $ref is not sufficient?

> +examples:
> +  - |
> +    #include <dt-bindings/clock/imx6sx-clock.h>
> +
> +    iomuxc-gpr@20e4000 {

syscon@ please.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2023-05-19 19:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 12:52 [PATCH v4 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Fabio Estevam
2023-05-19 12:52 ` [PATCH v4 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register Fabio Estevam
2023-05-19 13:24   ` Rob Herring
2023-05-19 15:45     ` Fabio Estevam
2023-05-19 19:23   ` Conor Dooley [this message]
2023-05-22 11:49     ` Fabio Estevam
2023-05-22 12:07       ` Conor Dooley
2023-05-19 12:52 ` [PATCH v4 3/4] ARM: dts: imx6sx: Add LDB support Fabio Estevam
2023-05-19 12:52 ` [PATCH v4 4/4] soc: imx: imx6sx-gpr: Introduce a GPR driver Fabio Estevam
2023-05-20 10:15 ` [PATCH v4 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230519-floral-diagram-894858b940c1@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox