From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872C9C77B7A for ; Fri, 19 May 2023 15:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232065AbjESPVB (ORCPT ); Fri, 19 May 2023 11:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbjESPVA (ORCPT ); Fri, 19 May 2023 11:21:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C220106; Fri, 19 May 2023 08:20:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ADF3C6589C; Fri, 19 May 2023 15:20:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8010EC433D2; Fri, 19 May 2023 15:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684509658; bh=+sp/ndddAwmlf9DWqKIi7xyEcvpuzEhQ/izOrZupQBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tI85oLMhhqyZ+sHiiL2LjTi9fn3cFnL3J+G6CQZIQR6SuNaqeoeRRvopjVt8WXmYn LxE2Ih/PvNp1ALUNz53I8YOpxP8bWTZPlYd3F/taektr9gjROyCKT9W2YjUUnobeq+ nPMt42UM+adRpqdSPZY2muN53SN3px2X2VNfdWYrE2d31rO/RYeqpclcd8n1aWsXiZ TAHfnRSx4MfYBSnnf3YtVYcIspWdtn8p4weHHRg545Ss9YBiiNNC7Sqk/xB6CVugYY x9NWIcexVZGYOS7D1/ttKvIpzFIdKnE1BgWmZH0ESTAf7fhUNSZVW2yV9i8APmw0U6 /Q3zefZWdICTg== Date: Fri, 19 May 2023 16:20:53 +0100 From: Conor Dooley To: Geert Uytterhoeven Cc: Biju Das , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Geert Uytterhoeven , Magnus Damm , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Fabrizio Castro Subject: Re: [PATCH v4 09/11] regulator: dt-bindings: Add Renesas RAA215300 PMIC bindings Message-ID: <20230519-giving-proven-1133875db395@spud> References: <20230518113643.420806-1-biju.das.jz@bp.renesas.com> <20230518113643.420806-10-biju.das.jz@bp.renesas.com> <20230518-prompter-helium-91d0139a61e2@spud> <20230519-civic-idiocy-5ac6d95675f0@wendy> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2EvJa2hO2K2Spwku" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --2EvJa2hO2K2Spwku Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 19, 2023 at 04:49:44PM +0200, Geert Uytterhoeven wrote: > On Fri, May 19, 2023 at 4:39=E2=80=AFPM Biju Das wrote: > > > -----Original Message----- > > > From: Conor Dooley > > > On Fri, May 19, 2023 at 06:53:03AM +0000, Biju Das wrote: > > > > > Subject: Re: [PATCH v4 09/11] regulator: dt-bindings: Add Renesas > > > > > > +required: > > > > > > + - compatible > > > > > > + - reg > > > > > > + - reg-names > > > > > > > > > > Out of curiosity as much as anything else, why do you need reg-na= mes > > > > > if the two registers are always required? > > OK, will drop reg-names from required property. >=20 > Please don't, as i2c_new_ancillary_device() does rely on the name > to set the address when overriding from the default. That looks like my answer! Thanks Geert & sorry for the noise here. Modulo Geert's requested change, I think I owe you a Reviewed-by: Conor Dooley Biju. Thanks, Conor. --2EvJa2hO2K2Spwku Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGeT1AAKCRB4tDGHoIJi 0iv1APwKw8DY6iGSq0dYCscL2F8wST//cz74mUwJrtHU9IXEGAEA0T+TAKWNc03n cN5TfV6iKpIw+NOw+EEKLNPktYSAGgU= =u/bs -----END PGP SIGNATURE----- --2EvJa2hO2K2Spwku--