From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Anup Sharma <anupnewsmail@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
u.kleine-koenig@pengutronix.de,
andriy.shevchenko@linux.intel.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Add dt-binding support for ti tmp006
Date: Sat, 20 May 2023 23:32:03 +0100 [thread overview]
Message-ID: <20230520-context-emblaze-2456dbeb2414@spud> (raw)
In-Reply-To: <20230520162002.7aba7c04@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On Sat, May 20, 2023 at 04:20:02PM +0100, Jonathan Cameron wrote:
> On Sat, 20 May 2023 16:21:50 +0530
> Anup Sharma <anupnewsmail@gmail.com> wrote:
>
> > These patches introduce device tree binding support and
> > add an of_device_id table entry to the driver.
> >
> > Changes in v2:
> > - Keep the exsisting MODULE_DEVICE_TABLE entry.
> > - Removed the inner comma in of_device_id.
> > - Order the included header to improve code organization.
> > - Adding missing semicolon to fix syntax error detected
> > using dt_binding_check.
> >
> LGTM - I'll leave them a little while though for others to comment before
> picking them up.
It may be a wee bit before you here from Krzysztof, but the binding
check issues have been fixed, as have the things he pointed out in the
original submission AFAICT.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-20 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 10:51 [PATCH v2 0/2] Add dt-binding support for ti tmp006 Anup Sharma
2023-05-20 10:53 ` [PATCH v2 1/2] dt-bindings: iio: temperature: Add support for tmp006 Anup Sharma
2023-05-20 10:55 ` [PATCH v2 2/2] iio: temperature: tmp006: Add OF device matching support Anup Sharma
2023-05-20 15:20 ` [PATCH v2 0/2] Add dt-binding support for ti tmp006 Jonathan Cameron
2023-05-20 22:32 ` Conor Dooley [this message]
2023-05-28 19:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520-context-emblaze-2456dbeb2414@spud \
--to=conor@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anupnewsmail@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).