From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C65E6C77B7D for ; Sat, 20 May 2023 15:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbjETPov (ORCPT ); Sat, 20 May 2023 11:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbjETPov (ORCPT ); Sat, 20 May 2023 11:44:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 472F2BF; Sat, 20 May 2023 08:44:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D45DA611F0; Sat, 20 May 2023 15:44:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAE1EC433D2; Sat, 20 May 2023 15:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684597489; bh=RFRzEGWghO4yi2OnUCzx9pLNfSOFFDNaFEjc9XDX0TQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rEOnab3rLPKsb5cBMoIlJCKqhQI1JKt8sxj1pObn3ESiB69HHsVq8z8ZoZoAUeSUi GRleOA1CQQrqWdBHvz/GrOSdhM9F0eRMbD/AZ2KF1W/hLRBJ0E7u+RGaPUJijY32ot C/3PvbCnRtOZ9m/1F6Th4q4/cPOh0wZRqpYpjofx4NazZy510JZ1AI2WaAy23HUhWO ZlhqEU7iquUPULCgKebFLWXor15AVMQKphe3FR47MwAZq2N7ENmDihBD1zcdtGnrf7 nzbEaqf8dmCvzdeaVJtz50s32kcCgkOL8e3WkXPZVYO8VOUpQ3pUgT9fMmtV/xiULd PH2uJ4PWcnAlQ== Date: Sat, 20 May 2023 17:00:57 +0100 From: Jonathan Cameron To: Shreeya Patel Cc: lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sebastian.reichel@collabora.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, gustavo.padovan@collabora.com, serge.broslavsky@collabora.com Subject: Re: [PATCH 0/7] RK3588 ADC support Message-ID: <20230520170057.12bf613f@jic23-huawei> In-Reply-To: <20230516230051.14846-1-shreeya.patel@collabora.com> References: <20230516230051.14846-1-shreeya.patel@collabora.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 17 May 2023 04:30:44 +0530 Shreeya Patel wrote: > This patch series adds ADC support for RK3588 and updates > the DT bindings for the same. > > To test ADC support on Rock 5B board, a voltage divider circuit > was created using the gpio pin 22 ( SARADC_IN4 ) and few more > tests were ran for testing the buffer and trigger using the > iio_generic_buffer tool. > > Shreeya Patel (7): > iio: adc: rockchip_saradc: Add support for RK3588 > iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled > iio: adc: rockchip_saradc: Use of_device_get_match_data > iio: adc: rockchip_saradc: Match alignment with open parenthesis > iio: adc: rockchip_saradc: Use dev_err_probe > arm64: dts: rockchip: Add DT node for ADC support in RK3588 > dt-bindings: iio: adc: Add rockchip,rk3588-saradc string > > .../bindings/iio/adc/rockchip-saradc.yaml | 1 + > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 12 + > drivers/iio/adc/rockchip_saradc.c | 260 ++++++++++-------- > 3 files changed, 164 insertions(+), 109 deletions(-) > Patches I haven't commented on all look fine to me. Thanks, Jonathan