From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] iio: pressure: Honeywell mprls0025pa pressure sensor
Date: Sat, 20 May 2023 17:35:36 +0100 [thread overview]
Message-ID: <20230520173536.6597aa21@jic23-huawei> (raw)
In-Reply-To: <ZGNawohZTDhPazil@arbad>
On Tue, 16 May 2023 12:28:18 +0200
Andreas Klinger <ak@it-klinger.de> wrote:
> Hi Jonathan,
>
> thanks for your review. I have one comment.
>
> Jonathan Cameron <jic23@kernel.org> schrieb am Sa, 06. Mai 17:04:
> > > + int scale; /* int part of scale */
> > > + int scale2; /* nano part of scale */
> > > + int offset; /* int part of offset */
> > > + int offset2; /* nano part of offset */
> > > + struct gpio_desc *gpiod_reset; /* reset */
> > > + int irq; /* end of conversion irq */
> >
> > Only needed in probe, no need for a copy in here.
>
> It's also used in mpr_read_pressure() to distinguish the two possible operation
> modes:
> - waiting for an interrupt
> - reading in a loop until status indicates data ready
>
Oops. Thanks for pointing that out!
> Andreas
next prev parent reply other threads:[~2023-05-20 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 13:19 [PATCH v4 0/3] Support Honeywell mprls0025pa pressure sensor Andreas Klinger
2023-05-05 13:21 ` [PATCH v4 1/3] dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor Andreas Klinger
2023-05-05 16:48 ` Krzysztof Kozlowski
2023-05-05 13:22 ` [PATCH v4 2/3] iio: pressure: Honeywell mprls0025pa pressure sensor Andreas Klinger
2023-05-05 16:55 ` kernel test robot
2023-05-06 16:04 ` Jonathan Cameron
2023-05-16 10:28 ` Andreas Klinger
2023-05-20 16:35 ` Jonathan Cameron [this message]
2023-05-05 13:22 ` [PATCH v4 3/3] MAINTAINERS: Add Honeywell mprls0025pa sensor Andreas Klinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520173536.6597aa21@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).