From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B821C7EE2A for ; Sun, 21 May 2023 17:14:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbjEURNj (ORCPT ); Sun, 21 May 2023 13:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbjEURKr (ORCPT ); Sun, 21 May 2023 13:10:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D159FE74; Sun, 21 May 2023 10:08:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6649960FE3; Sun, 21 May 2023 17:08:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1780AC433D2; Sun, 21 May 2023 17:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684688917; bh=EA/dMN8uSmBLu0XJzQQrrnI0PyUW/NRfOEu9PpWl6rY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P5Be11gQhXTmIpiBfldqTfPjPIpLCHql53dVblRRB+MMAJDOYixcoh3wUOO2c/kto 6Li2ifUIM10h7J9+0HbhfcE12usA1k5mamV27sG9eQbERsm5upJe9EYH+3qH2oUpvG tBlTeoWnOyByQY79USYdL5tZuJrYPqi5QC/HqKTy3P6DbnPd+U9FPSEY27foEyiPGB +US7bShnmG+9AmF+fS8sZvT3i+6o45VH0Zi/05lz8OkrHK+IVIZ2pJXqjV+hkysmoM pWTa9yx6SYBE0Or3PYDXAYqVK5oiGvZslnkMm39RsGYi4qafAWe9DKjS3uMOHDzBWU /t+uJOGSfCojg== Date: Sun, 21 May 2023 18:08:32 +0100 From: Conor Dooley To: Guo Ren Cc: Jisheng Zhang , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, heiko@sntech.de Subject: Re: [PATCH 3/5] riscv: dts: add initial T-HEAD light SoC device tree Message-ID: <20230521-licorice-follicle-2f83e82f8bce@spud> References: <20230507182304.2934-1-jszhang@kernel.org> <20230507182304.2934-4-jszhang@kernel.org> <20230507-calamari-gentleman-bbe62af06f92@spud> <20230508-unmoved-unvocal-9a6c5fc0c629@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8G3irSIrB1WawZQb" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --8G3irSIrB1WawZQb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 21, 2023 at 11:37:58PM +0800, Guo Ren wrote: > On Tue, May 9, 2023 at 12:44=E2=80=AFAM Conor Dooley w= rote: > > > > On Tue, May 09, 2023 at 12:26:10AM +0800, Jisheng Zhang wrote: > > > On Sun, May 07, 2023 at 10:35:12PM +0100, Conor Dooley wrote: > > > > On Mon, May 08, 2023 at 02:23:02AM +0800, Jisheng Zhang wrote: > > > > > > > > > + c910_0: cpu@0 { > > > > > + compatible =3D "thead,c910", "riscv"; > > > > > + device_type =3D "cpu"; > > > > > + riscv,isa =3D "rv64imafdc"; > > > > > > > > Does this support more than "rv64imafdc"? > > > > I assume there's some _xtheadfoo extensions that it does support, > > > > although I am not sure how we are proceeding with those - Heiko mig= ht > > > > have a more nuanced take. > > > > > > > > > + reset: reset-sample { > > > > > + compatible =3D "thead,reset-sample"; > > > > > > > > What is a "reset-sample"? > > > > > > This node is only for opensbi. The compatible string is already in > > > opensbi. Do we also need to add dt-binding for it in linux? > > > > If it's to be included in the kernel's dts, then yes, you do need a > > dt-binding. If you remove it, then you don't :) > > > > That said, "thead,reset-sample" is a strangely named compatible, so if > > you do keep it it may end up needing a rename! > How about compatible =3D "thead,reset-th1520" ? "vendor,soc-function" is more typical, but "reset" is usually used for reset controllers of which this isn't as far as I can tell. I commented on the v2, hoping that you might actually know what the IP block' full/proper name is: https://lore.kernel.org/all/20230518-driving-secluding-793b3192776e@spud/ Do you? Cheers, Conor. --8G3irSIrB1WawZQb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGpQEAAKCRB4tDGHoIJi 0kCCAP9n2k/2fmZwxGGppz0pZC0qiT6h8lZ8vMVzSsmZd2NsAQD+J2Tr7Hxg2Bgt tnCER3gtzOoAHhHn+MwFUX4Oy4EtugU= =DDuI -----END PGP SIGNATURE----- --8G3irSIrB1WawZQb--