From: Conor Dooley <conor@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
bcm-kernel-feedback-list@broadcom.com,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Christian Lamparter" <chunkeey@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] dt-bindings: arm: bcm: unify version notation of Northstar devices
Date: Mon, 22 May 2023 18:08:35 +0100 [thread overview]
Message-ID: <20230522-bacterium-quality-b51ee7dc124c@spud> (raw)
In-Reply-To: <20230520112601.11821-1-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2163 bytes --]
On Sat, May 20, 2023 at 01:26:00PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Always use a minus/hyphen char to separate model from version. This
> unifies binding's "compatible" strings.
Am I just being paranoid in thinking that software may have relied on
the former naming scheme?
On the other hand, my OCD really likes the change.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> index 454b0e93245d..cc34025fdc78 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml
> @@ -28,10 +28,10 @@ properties:
> - buffalo,wzr-1750dhp
> - linksys,ea6300-v1
> - linksys,ea6500-v2
> - - luxul,xap-1510v1
> + - luxul,xap-1510-v1
> - luxul,xwc-1000
> - - netgear,r6250v1
> - - netgear,r6300v2
> + - netgear,r6250-v1
> + - netgear,r6300-v2
> - smartrg,sr400ac
> - brcm,bcm94708
> - const: brcm,bcm4708
> @@ -42,8 +42,8 @@ properties:
> - asus,rt-n18u
> - buffalo,wzr-600dhp2
> - buffalo,wzr-900dhp
> - - luxul,xap-1410v1
> - - luxul,xwr-1200v1
> + - luxul,xap-1410-v1
> + - luxul,xwr-1200-v1
> - tplink,archer-c5-v2
> - const: brcm,bcm47081
> - const: brcm,bcm4708
> @@ -72,7 +72,7 @@ properties:
> - luxul,xap-1610-v1
> - luxul,xbr-4500-v1
> - luxul,xwc-2000-v1
> - - luxul,xwr-3100v1
> + - luxul,xwr-3100-v1
> - luxul,xwr-3150-v1
> - netgear,r8500
> - phicomm,k3
> --
> 2.35.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-22 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 11:26 [PATCH 1/2] dt-bindings: arm: bcm: unify version notation of Northstar devices Rafał Miłecki
2023-05-20 11:26 ` [PATCH 2/2] ARM: dts: BCM5301X: Use updated device "compatible" strings Rafał Miłecki
2023-05-20 18:31 ` Linus Walleij
2023-05-25 17:41 ` Florian Fainelli
2023-05-20 18:30 ` [PATCH 1/2] dt-bindings: arm: bcm: unify version notation of Northstar devices Linus Walleij
2023-05-22 17:08 ` Conor Dooley [this message]
2023-05-22 20:29 ` Rafał Miłecki
2023-05-23 16:07 ` Conor Dooley
2023-06-01 7:07 ` Krzysztof Kozlowski
2023-05-25 17:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522-bacterium-quality-b51ee7dc124c@spud \
--to=conor@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chunkeey@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).