From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C72DC7EE2A for ; Mon, 22 May 2023 19:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234578AbjEVTYu (ORCPT ); Mon, 22 May 2023 15:24:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234591AbjEVTYr (ORCPT ); Mon, 22 May 2023 15:24:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD6D9CF; Mon, 22 May 2023 12:24:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A3576287A; Mon, 22 May 2023 19:24:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA9C2C4339B; Mon, 22 May 2023 19:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684783485; bh=RSKvD+Gg0X0tn8/0dtsFGEkG2OQ9a7Azcy+M2cqCDiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jXOEwZO7yCqNHHQ+wkO8E6g3WIXsWRU3srInmTFq8BCIGKR6udYIPuoEiRw8PZQKd jKND4lNpZDcbU+a0u6vsqN/62wK5cUl+kdUtxpETwgnR54a1P65aCh+1QZQxbZNsXZ kbTNnbD7SpeOWKPqks2ewaxWsE6DGAWKZgSuD78phXDfug7yEXYKznHTdAlN8ncTGI uKI6MabT3RF9B4kbAxS1o07SnD/ICx+IgVKcPmVzdXoLgGjJclbpdoITAz+DgbkTO9 oZ8Sk5dAooYC+KCW4CpTQf907LF+ffSaJys863uMg2iGzHNZpNqv4wy9nCy7Om6m+h 4Fq9Sxi5oPKLQ== Date: Mon, 22 May 2023 20:24:40 +0100 From: Conor Dooley To: Sebastian Reichel Cc: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Damien Le Moal , Serge Semin , Vinod Koul , Kishon Vijay Abraham I , linux-ide@vger.kernel.org, linux-phy@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 4/6] dt-bindings: phy: rockchip: rk3588 has two reset lines Message-ID: <20230522-blanching-unfiled-b89a4378622e@spud> References: <20230522173423.64691-1-sebastian.reichel@collabora.com> <20230522173423.64691-5-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XlKnjVVIuNeAc4md" Content-Disposition: inline In-Reply-To: <20230522173423.64691-5-sebastian.reichel@collabora.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --XlKnjVVIuNeAc4md Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Sebastian, On Mon, May 22, 2023 at 07:34:21PM +0200, Sebastian Reichel wrote: > The RK3588 has two reset lines for the combphy. One for the > APB interface and one for the actual PHY. But the 68 only has one? Should per-compatible enforcement be added like you added for the clocks? > Signed-off-by: Sebastian Reichel > --- > .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-co= mbphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-comb= phy.yaml > index 9ae514fa7533..82550a5c2ed5 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.y= aml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.y= aml > @@ -31,8 +31,14 @@ properties: > - const: pipe > =20 > resets: > + minItems: 1 > + maxItems: 2 > + > + reset-names: > + minItems: 1 > items: > - - description: exclusive PHY reset line > + - const: phy > + - const: apb > =20 > rockchip,enable-ssc: > type: boolean > --=20 > 2.39.2 >=20 --XlKnjVVIuNeAc4md Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGvBeAAKCRB4tDGHoIJi 0ulrAQDdVYZ0XlkyJr9Pk+AzBZf9DYBqLoF3J5agxBBphJ/icAD+Ps9MqBbyxLxN Wtkf7n3izQhheQvLbTM0gYlDXt8TzgU= =I8fK -----END PGP SIGNATURE----- --XlKnjVVIuNeAc4md--