From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269A2C77B75 for ; Mon, 22 May 2023 07:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbjEVHOS (ORCPT ); Mon, 22 May 2023 03:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231867AbjEVHOD (ORCPT ); Mon, 22 May 2023 03:14:03 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC90510FA; Mon, 22 May 2023 00:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1684739614; x=1716275614; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=w/k9h1UfGfI/AZPgaI1qAV5bL2MNw9A/V2b2Qrn5ntY=; b=vfWcnD9ikzuedszlEx7TnQeBUbCPkMU2onoZ44NcypcHftX6lLMHfJnn datwA8ljFsrDlOXA+blGvfAd7HcLTegkEDzEe3ry2kxVG3rX7w41ZvTch 3YvRQ7g4YQguD7qECb4rXgCn7czyDdhAtSsgRtFJQbSL5s27yts+NsSJP f8ZYAxdT1p8n3MYFne8YrA448SeZu2trSaJlhnlhY2Ig47x9yUdpX7xa2 y1bH/p050gTq/TN1MXGgyExtDg3hBAGKL2/cj/ti/aalyL4ydtDwKkt2f XD3EJP72OTplCzjSTGd9s8TpFNIgBJUqtdu8PwQxiZpyjXqfiATMqq9TZ g==; X-IronPort-AV: E=Sophos;i="6.00,183,1681196400"; d="asc'?scan'208";a="214867004" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 May 2023 00:13:30 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 22 May 2023 00:13:29 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 22 May 2023 00:13:26 -0700 Date: Mon, 22 May 2023 08:13:04 +0100 From: Conor Dooley To: Jisheng Zhang CC: Samuel Holland , , , , , Palmer Dabbelt , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH v4 03/10] dt-bindings: serial: add documentation for Bouffalolab UART Driver Message-ID: <20230522-cedar-undertow-a4f274ef1cec@wendy> References: <20230518152244.2178-1-jszhang@kernel.org> <20230518152244.2178-4-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1eDfFFL/98DJ7Ge8" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --1eDfFFL/98DJ7Ge8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 21, 2023 at 05:13:38PM +0800, Jisheng Zhang wrote: > On Thu, May 18, 2023 at 10:00:50PM -0500, Samuel Holland wrote: > > On 5/18/23 10:22, Jisheng Zhang wrote: > > This is not complete. There are separate APB and module (baud) clocks, > > as well as a peripheral reset line. If we are going to keep the binding > > stable, these need to be described up front. >=20 > IIUC, the only requirement is to keep the driver compatible with both > new dts and old dts. clk tree and reset can be added latter. I have seen > sevral such examples from other SoCs' mainline progress. It is generally preferred to add bindings in as complete a state as possible. The driver doesn't need to actually make use of all of the properties though, and can add the other bits as if/when they are required. Cheers, Conor. --1eDfFFL/98DJ7Ge8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGsWAAAKCRB4tDGHoIJi 0tUZAP4xFzpnPXGNvSX7grsLiurDrx4Hcr8BrIW1/vGAaKftmgEAurntuZJHchju rEhU8AQ0jC/jDWmfjG4A+v/JrI1IxQM= =em4o -----END PGP SIGNATURE----- --1eDfFFL/98DJ7Ge8--