Re: [PATCH v8 2/4] crypto: starfive - Add crypto engine support

[Conor Dooley <conor.dooley@microchip.com>]

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

On Mon, May 15, 2023 at 08:53:53PM +0800, Jia Jie Ho wrote:
> +config CRYPTO_DEV_JH7110
> +	tristate "StarFive JH7110 cryptographic engine driver"
> +	depends on SOC_STARFIVE || COMPILE_TEST
> +	select CRYPTO_ENGINE
> +	select ARM_AMBA

I have yet to bisect, but I think this has broken the build on RISC-V:
drivers/dma/pl330.c:1053:13: error: redefinition of '_start' as different kind of symbol
static bool _start(struct pl330_thread *thrd)
            ^
arch/riscv/include/asm/sections.h:11:13: note: previous definition is here
extern char _start[];
            ^
drivers/dma/pl330.c:1705:10: error: called object type 'char[]' is not a function or function pointer
                        _start(thrd);
                        ~~~~~~^
drivers/dma/pl330.c:2092:9: error: called object type 'char[]' is not a function or function pointer
                _start(pch->thread);
                ~~~~~~^
drivers/dma/pl330.c:2110:11: error: called object type 'char[]' is not a function or function pointer
                                _start(pch->thread);
                                ~~~~~~^
4 errors generated.

The pl330 dma driver depends on ARM_AMBA.

Cheers,
Conor.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]