From: Conor Dooley <conor.dooley@microchip.com>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Tiezhu Yang <yangtiezhu@loongson.cn>,
Marc Zyngier <maz@kernel.org>,
Youling Tang <tangyouling@loongson.cn>,
Baoqi Zhang <zhangbaoqi@loongson.cn>,
Arnd Bergmann <arnd@arndb.de>, Yun Liu <liuyun@loongson.cn>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <loongarch@lists.linux.dev>,
Jianmin Lv <lvjianmin@loongson.cn>, <wanghongliang@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>,
<loongson-kernel@lists.loongnix.cn>
Subject: Re: [PATCH v2 2/3] dt-bindings: soc: add loongson-2 pm
Date: Mon, 22 May 2023 13:47:37 +0100 [thread overview]
Message-ID: <20230522-kooky-outbid-82662b45d305@wendy> (raw)
In-Reply-To: <20230522093156.7108-3-zhuyinbo@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 3024 bytes --]
Hey!
On Mon, May 22, 2023 at 05:31:55PM +0800, Yinbo Zhu wrote:
> Add the Loongson-2 SoC Power Management Controller binding with DT
> schema format using json-schema.
Grabbing thread from lore.kernel.org/all/20230522093156.7108-3-zhuyinbo%40loongson.cn/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 3 messages in the thread
Checking attestation on all messages, may take a moment...
---
[PATCH v2 1/3] loongarch: export loongarch pm interface
+ Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
[PATCH v2 2/3] dt-bindings: soc: add loongson-2 pm
+ Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
ERROR: missing [3/3]!
---
Total patches: 2
---
WARNING: Thread incomplete!
Applying: loongarch: export loongarch pm interface
Applying: dt-bindings: soc: add loongson-2 pm
Looks like the user for these bindings got lost somewhere along the way?
Please make sure to keep a series threaded.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> .../soc/loongson/loongson,ls2k-pmc.yaml | 51 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml b/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml
> new file mode 100644
> index 000000000000..ddad62889c60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/loongson/loongson,ls2k-pmc.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/loongson/loongson,ls2k-pmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson-2 Power Manager controller
> +
> +maintainers:
> + - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - loongson,ls2k-pmc
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + suspend-address:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + The "suspend-address" is a deep sleep state (Suspend To RAM)
> + firmware entry address which was jumped from kernel and it's
> + value was dependent on specific platform firmware code. In
> + addition, the PM need according to it to indicate that current
> + SoC whether support Suspend To RAM.
I (still) think this property is rather odd, maybe I am just not really
understanding the property as it seems to be described partly in terms
of operating system behaviour rather than its actual function. "was
jumped from kernel" I don't get.
The whole setup here seems a bit odd, but that's for the loongson arch
folks reviewing the actual code to comment on!
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-22 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 9:31 [PATCH v2 0/3] soc: loongson2_pm: add power management support Yinbo Zhu
2023-05-22 9:31 ` [PATCH v2 1/3] loongarch: export loongarch pm interface Yinbo Zhu
2023-05-24 1:57 ` Huacai Chen
2023-05-24 3:41 ` zhuyinbo
2023-05-22 9:31 ` [PATCH v2 2/3] dt-bindings: soc: add loongson-2 pm Yinbo Zhu
2023-05-22 12:47 ` Conor Dooley [this message]
2023-05-23 3:22 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522-kooky-outbid-82662b45d305@wendy \
--to=conor.dooley@microchip.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=liuyun@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=maz@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tangyouling@loongson.cn \
--cc=wanghongliang@loongson.cn \
--cc=yangtiezhu@loongson.cn \
--cc=zhangbaoqi@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox