Re: [PATCH 1/2] dt-bindings: arm: bcm: unify version notation of Northstar devices

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

On Mon, May 22, 2023 at 10:29:38PM +0200, Rafał Miłecki wrote:
> On 22.05.2023 19:08, Conor Dooley wrote:
> > On Sat, May 20, 2023 at 01:26:00PM +0200, Rafał Miłecki wrote:
> > > From: Rafał Miłecki <rafal@milecki.pl>
> > > 
> > > Always use a minus/hyphen char to separate model from version. This
> > > unifies binding's "compatible" strings.
> > 
> > Am I just being paranoid in thinking that software may have relied on
> > the former naming scheme?
> > On the other hand, my OCD really likes the change.
> 
> That's a very reasonable concern.
> 
> 
> TLDR: The risk of any breakage is extremely low due to Northstar CFE
> bootloader & projects with Northstar support.
> 
> 
> There are very few Northstar devices with bootloader other than CFE.
> All devices affected by this PATCH use CFE actually.
> CFE on Northstar has no support for DTS (DTB).
> DTB files are always appended to kernel on all affected devices.
> 
> So problem of some DTB stored in bootloader getting out of sync with
> kernel / user-space is non-existent in this case.
> 
> We still should consider a risk of some out-of-tree driver or just
> user-space checking for those compatible strings. I'm not aware of any
> project other than OpenWrt providing system images for those devices.
> There is some basic support in buildroot but it's quite dead. Even in
> OpenWrt case the only possibly affected device is Netgear R6300 V2.
> OpenWrt doesn't provide images for any of affected Luxul devices.
> 
> So there isn't any known project this change can actually break. If
> there is one (very unlikely) it can still update its user-space or
> out of kernel driver while updating DTB.
> 
> So while this change may be not the best approach (in general terms)
> in this case it's very unlikely to break anything.

Okay. I think this sounds reasonable to do then. Thanks for the
explanation :)
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]