From: Conor Dooley <conor@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com, justinpopo6@gmail.com,
f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, opendmb@gmail.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
richardcochran@gmail.com, sumit.semwal@linaro.org,
christian.koenig@amd.com, simon.horman@corigine.com,
Florian Fainelli <florian.fainelli@broadcom.com>
Subject: Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller
Date: Tue, 23 May 2023 23:54:57 +0100 [thread overview]
Message-ID: <20230523-unfailing-twisting-9cb092b14f6f@spud> (raw)
In-Reply-To: <1684878827-40672-3-git-send-email-justin.chen@broadcom.com>
Hey Justin,
On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote:
> + compatible:
> + enum:
> + - brcm,asp-v2.0
> + - brcm,bcm72165-asp
> + - brcm,asp-v2.1
> + - brcm,bcm74165-asp
> + compatible = "brcm,bcm72165-asp", "brcm,asp-v2.0";
You can't do this, as Rob's bot has pointed out. Please test the
bindings :( You need one of these type of constructs:
compatible:
oneOf:
- items:
- const: brcm,bcm72165-asp
- const: brcm,asp-v2.0
- items:
- const: brcm,bcm74165-asp
- const: brcm,asp-v2.1
Although, given either you or Florian said there are likely to be
multiple parts, going for an enum, rather than const for the brcm,bcm..
entry will prevent some churn. Up to you.
Cheers,
Conor.
next prev parent reply other threads:[~2023-05-23 22:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 21:53 [PATCH net-next v4 0/6] Brcm ASP 2.0 Ethernet Controller Justin Chen
2023-05-23 21:53 ` [PATCH net-next v4 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0 Justin Chen
2023-05-24 9:23 ` Simon Horman
2023-05-23 21:53 ` [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Justin Chen
2023-05-23 22:18 ` Rob Herring
2023-05-23 22:54 ` Conor Dooley [this message]
2023-05-23 23:27 ` Justin Chen
2023-05-24 6:51 ` Conor Dooley
2023-05-24 6:56 ` Conor Dooley
2023-05-24 21:47 ` Justin Chen
2023-05-24 21:54 ` Conor Dooley
2023-05-23 21:53 ` [PATCH net-next v4 3/6] net: bcmasp: Add support for ASP2.0 " Justin Chen
2023-05-24 9:19 ` Simon Horman
2023-05-23 21:53 ` [PATCH net-next v4 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support Justin Chen
2023-05-24 9:24 ` Simon Horman
2023-05-23 21:53 ` [PATCH net-next v4 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165 Justin Chen
2023-05-24 9:24 ` Simon Horman
2023-05-23 21:53 ` [PATCH net-next v4 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers Justin Chen
2023-05-24 9:22 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523-unfailing-twisting-9cb092b14f6f@spud \
--to=conor@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.koenig@amd.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=justinpopo6@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox