devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: Mystery dtb check errors with ti,x-plate-ohms with txt only binding
Date: Tue, 23 May 2023 09:01:28 +0300	[thread overview]
Message-ID: <20230523060128.GY14287@atomide.com> (raw)
In-Reply-To: <20230519151639.67s2gapqplys7gva@mercury.elektranox.org>

* Sebastian Reichel <sebastian.reichel@collabora.com> [230519 15:16]:
> Hi,
> 
> On Fri, May 19, 2023 at 10:13:59AM +0300, Tony Lindgren wrote:
> > Somehow the ti,x-plate-ohms property produces errors for nodes with the
> > compatible only in a txt binding that still uses /bits/ 16 value:
> > 
> > ti,x-plate-ohms: size (2) error for type uint32-array
> > 
> > For the yaml bindings, we have ti,xplate-ohms so far only defined in
> > Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.
> > 
> > So for example, compatible = "ti,tsc2046" that only has a txt binding in
> > Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still
> > produces warnings somehow based on the ti,tsc2005.yaml?
> > 
> > Any ideas why this is happening?
> 
> -ohms is a standard unit suffix and thus the property gets the type
> auto-assigned:
> 
> https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml#L64

OK thanks makes sense. Seems like the drivers should be fixed to just
parse uint32, then the bindings should be updated to use yaml.

Regards,

Tony



      reply	other threads:[~2023-05-23  6:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19  7:13 Mystery dtb check errors with ti,x-plate-ohms with txt only binding Tony Lindgren
2023-05-19 15:16 ` Sebastian Reichel
2023-05-23  6:01   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523060128.GY14287@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).