devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Mystery dtb check errors with ti,x-plate-ohms with txt only binding
@ 2023-05-19  7:13 Tony Lindgren
  2023-05-19 15:16 ` Sebastian Reichel
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2023-05-19  7:13 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski; +Cc: linux-omap, devicetree

Hi,

Somehow the ti,x-plate-ohms property produces errors for nodes with the
compatible only in a txt binding that still uses /bits/ 16 value:

ti,x-plate-ohms: size (2) error for type uint32-array

For the yaml bindings, we have ti,xplate-ohms so far only defined in
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.

So for example, compatible = "ti,tsc2046" that only has a txt binding in
Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still
produces warnings somehow based on the ti,tsc2005.yaml?

Any ideas why this is happening?

Regards,

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Mystery dtb check errors with ti,x-plate-ohms with txt only binding
  2023-05-19  7:13 Mystery dtb check errors with ti,x-plate-ohms with txt only binding Tony Lindgren
@ 2023-05-19 15:16 ` Sebastian Reichel
  2023-05-23  6:01   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Reichel @ 2023-05-19 15:16 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Rob Herring, Krzysztof Kozlowski, linux-omap, devicetree

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi,

On Fri, May 19, 2023 at 10:13:59AM +0300, Tony Lindgren wrote:
> Somehow the ti,x-plate-ohms property produces errors for nodes with the
> compatible only in a txt binding that still uses /bits/ 16 value:
> 
> ti,x-plate-ohms: size (2) error for type uint32-array
> 
> For the yaml bindings, we have ti,xplate-ohms so far only defined in
> Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.
> 
> So for example, compatible = "ti,tsc2046" that only has a txt binding in
> Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still
> produces warnings somehow based on the ti,tsc2005.yaml?
> 
> Any ideas why this is happening?

-ohms is a standard unit suffix and thus the property gets the type
auto-assigned:

https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml#L64

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Mystery dtb check errors with ti,x-plate-ohms with txt only binding
  2023-05-19 15:16 ` Sebastian Reichel
@ 2023-05-23  6:01   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2023-05-23  6:01 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Rob Herring, Krzysztof Kozlowski, linux-omap, devicetree

* Sebastian Reichel <sebastian.reichel@collabora.com> [230519 15:16]:
> Hi,
> 
> On Fri, May 19, 2023 at 10:13:59AM +0300, Tony Lindgren wrote:
> > Somehow the ti,x-plate-ohms property produces errors for nodes with the
> > compatible only in a txt binding that still uses /bits/ 16 value:
> > 
> > ti,x-plate-ohms: size (2) error for type uint32-array
> > 
> > For the yaml bindings, we have ti,xplate-ohms so far only defined in
> > Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.
> > 
> > So for example, compatible = "ti,tsc2046" that only has a txt binding in
> > Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still
> > produces warnings somehow based on the ti,tsc2005.yaml?
> > 
> > Any ideas why this is happening?
> 
> -ohms is a standard unit suffix and thus the property gets the type
> auto-assigned:
> 
> https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml#L64

OK thanks makes sense. Seems like the drivers should be fixed to just
parse uint32, then the bindings should be updated to use yaml.

Regards,

Tony



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-23  6:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-19  7:13 Mystery dtb check errors with ti,x-plate-ohms with txt only binding Tony Lindgren
2023-05-19 15:16 ` Sebastian Reichel
2023-05-23  6:01   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).