* [PATCH] arm64: dts: Unify pinctrl-single pin group nodes for altera
@ 2023-05-23 6:58 Tony Lindgren
2023-05-24 16:08 ` Dinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2023-05-23 6:58 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley; +Cc: devicetree
We want to unify the pinctrl-single pin group nodes to use naming "pins".
Otherwise non-standad pin group names will add make dtbs checks errors
when the pinctrl-single yaml binding gets merged.
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -66,14 +66,14 @@ sdmmca-ecc@ff8c8c00 {
};
&pinctrl0 {
- i2c1_pmx_func: i2c1-pmx-func {
+ i2c1_pmx_func: i2c1-pins {
pinctrl-single,pins = <
0x78 0x4 /* I2C1_SDA (IO6-B) PIN30SEL) */
0x7c 0x4 /* I2C1_SCL (IO7-B) PIN31SEL */
>;
};
- i2c1_pmx_func_gpio: i2c1-pmx-func-gpio {
+ i2c1_pmx_func_gpio: i2c1-gpio-pins {
pinctrl-single,pins = <
0x78 0x8 /* I2C1_SDA (IO6-B) PIN30SEL) */
0x7c 0x8 /* I2C1_SCL (IO7-B) PIN31SEL */
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: Unify pinctrl-single pin group nodes for altera
2023-05-23 6:58 [PATCH] arm64: dts: Unify pinctrl-single pin group nodes for altera Tony Lindgren
@ 2023-05-24 16:08 ` Dinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Dinh Nguyen @ 2023-05-24 16:08 UTC (permalink / raw)
To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley; +Cc: devicetree
On 5/23/23 01:58, Tony Lindgren wrote:
> We want to unify the pinctrl-single pin group nodes to use naming "pins".
> Otherwise non-standad pin group names will add make dtbs checks errors
> when the pinctrl-single yaml binding gets merged.
>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -66,14 +66,14 @@ sdmmca-ecc@ff8c8c00 {
> };
>
> &pinctrl0 {
> - i2c1_pmx_func: i2c1-pmx-func {
> + i2c1_pmx_func: i2c1-pins {
> pinctrl-single,pins = <
> 0x78 0x4 /* I2C1_SDA (IO6-B) PIN30SEL) */
> 0x7c 0x4 /* I2C1_SCL (IO7-B) PIN31SEL */
> >;
> };
>
> - i2c1_pmx_func_gpio: i2c1-pmx-func-gpio {
> + i2c1_pmx_func_gpio: i2c1-gpio-pins {
> pinctrl-single,pins = <
> 0x78 0x8 /* I2C1_SDA (IO6-B) PIN30SEL) */
> 0x7c 0x8 /* I2C1_SCL (IO7-B) PIN31SEL */
Applied!
Thanks,
Dinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-24 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-23 6:58 [PATCH] arm64: dts: Unify pinctrl-single pin group nodes for altera Tony Lindgren
2023-05-24 16:08 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).