devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Herve Codina <herve.codina@bootlin.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [PATCH v2 4/9] iio: consumer.h: Fix raw values documentation notes
Date: Tue, 23 May 2023 17:12:18 +0200	[thread overview]
Message-ID: <20230523151223.109551-5-herve.codina@bootlin.com> (raw)
In-Reply-To: <20230523151223.109551-1-herve.codina@bootlin.com>

The raw values notes mention 'ADC counts' and are not fully accurate.

Reword the notes in order to remove the 'ADC counts' and describe the
conversion needed between a raw value and a value in the standard units.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 include/linux/iio/consumer.h | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/include/linux/iio/consumer.h b/include/linux/iio/consumer.h
index 6802596b017c..f536820b9cf2 100644
--- a/include/linux/iio/consumer.h
+++ b/include/linux/iio/consumer.h
@@ -201,8 +201,9 @@ struct iio_dev
  * @chan:		The channel being queried.
  * @val:		Value read back.
  *
- * Note raw reads from iio channels are in adc counts and hence
- * scale will need to be applied if standard units required.
+ * Note, if standard units are required, raw reads from iio channels
+ * need the offset (default 0) and scale (default 1) to be applied
+ * as (raw + offset) * scale.
  */
 int iio_read_channel_raw(struct iio_channel *chan,
 			 int *val);
@@ -212,8 +213,9 @@ int iio_read_channel_raw(struct iio_channel *chan,
  * @chan:		The channel being queried.
  * @val:		Value read back.
  *
- * Note raw reads from iio channels are in adc counts and hence
- * scale will need to be applied if standard units required.
+ * Note, if standard units are required, raw reads from iio channels
+ * need the offset (default 0) and scale (default 1) to be applied
+ * as (raw + offset) * scale.
  *
  * In opposit to the normal iio_read_channel_raw this function
  * returns the average of multiple reads.
@@ -281,8 +283,9 @@ int iio_read_channel_attribute(struct iio_channel *chan, int *val,
  * @chan:		The channel being queried.
  * @val:		Value being written.
  *
- * Note raw writes to iio channels are in dac counts and hence
- * scale will need to be applied if standard units required.
+ * Note that for raw writes to iio channels, if the value provided is
+ * in standard units, the affect of the scale and offset must be removed
+ * as (value / scale) - offset.
  */
 int iio_write_channel_raw(struct iio_channel *chan, int val);
 
@@ -292,8 +295,9 @@ int iio_write_channel_raw(struct iio_channel *chan, int val);
  * @chan:		The channel being queried.
  * @val:		Value read back.
  *
- * Note raw reads from iio channels are in adc counts and hence
- * scale will need to be applied if standard units are required.
+ * Note, if standard units are required, raw reads from iio channels
+ * need the offset (default 0) and scale (default 1) to be applied
+ * as (raw + offset) * scale.
  */
 int iio_read_max_channel_raw(struct iio_channel *chan, int *val);
 
@@ -308,8 +312,9 @@ int iio_read_max_channel_raw(struct iio_channel *chan, int *val);
  * For ranges, three vals are always returned; min, step and max.
  * For lists, all the possible values are enumerated.
  *
- * Note raw available values from iio channels are in adc counts and
- * hence scale will need to be applied if standard units are required.
+ * Note, if standard units are required, raw available values from iio
+ * channels need the offset (default 0) and scale (default 1) to be applied
+ * as (raw + offset) * scale.
  */
 int iio_read_avail_channel_raw(struct iio_channel *chan,
 			       const int **vals, int *length);
-- 
2.40.1


  parent reply	other threads:[~2023-05-23 15:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23 15:12 [PATCH v2 0/9] Add support for IIO devices in ASoC Herve Codina
2023-05-23 15:12 ` [PATCH v2 1/9] ASoC: dt-bindings: Add audio-iio-aux Herve Codina
2023-05-23 15:12 ` [PATCH v2 2/9] ASoC: dt-bindings: simple-card: Add additional-devs subnode Herve Codina
2023-05-23 15:12 ` [PATCH v2 3/9] iio: inkern: Check error explicitly in iio_channel_read_max() Herve Codina
2023-05-28 17:32   ` Jonathan Cameron
2023-05-23 15:12 ` Herve Codina [this message]
2023-05-28 17:29   ` [PATCH v2 4/9] iio: consumer.h: Fix raw values documentation notes Jonathan Cameron
2023-05-23 15:12 ` [PATCH v2 5/9] iio: inkern: Add a helper to query an available minimum raw value Herve Codina
2023-05-28 17:33   ` Jonathan Cameron
2023-06-03 14:04   ` andy.shevchenko
2023-06-05  7:46     ` Herve Codina
2023-06-05  9:45       ` Andy Shevchenko
2023-06-05 14:11         ` Herve Codina
2023-06-05 17:05         ` Jonathan Cameron
2023-06-05 17:36           ` Herve Codina
2023-05-23 15:12 ` [PATCH v2 6/9] ASoC: soc-dapm.h: Add a helper to build a DAPM widget dynamically Herve Codina
2023-06-03 14:07   ` andy.shevchenko
2023-06-05  8:54     ` Herve Codina
2023-06-05 12:35     ` Herve Codina
2023-05-23 15:12 ` [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices Herve Codina
2023-05-28 17:38   ` Jonathan Cameron
2023-06-05 17:22     ` Herve Codina
2023-06-03 18:26   ` andy.shevchenko
2023-06-06 13:54     ` Herve Codina
2023-06-06 14:34       ` Andy Shevchenko
2023-06-07 14:56         ` Herve Codina
2023-06-07 13:23       ` Herve Codina
2023-05-23 15:12 ` [PATCH v2 8/9] ASoC: simple-card: Add missing of_node_put() in case of error Herve Codina
2023-05-23 23:24   ` Kuninori Morimoto
2023-05-23 15:12 ` [PATCH v2 9/9] ASoC: simple-card: Handle additional devices Herve Codina
2023-05-24  0:08   ` Kuninori Morimoto
2023-05-24  0:36     ` Kuninori Morimoto
2023-05-24 12:14     ` Herve Codina
2023-05-25  0:01       ` Kuninori Morimoto
2023-05-26 13:07         ` Herve Codina
2023-05-29  0:18           ` Kuninori Morimoto
2023-06-03 18:27   ` andy.shevchenko
2023-05-26 16:31 ` (subset) [PATCH v2 0/9] Add support for IIO devices in ASoC Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523151223.109551-5-herve.codina@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).