Re: [PATCH 1/6] dt-bindings: mfd: qcom,spmi-pmic: Document pmi8998 charger

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Wed, May 24, 2023 at 08:53:27PM +0100, Caleb Connolly wrote:
> On 24/05/2023 20:02, Conor Dooley wrote:
> > Hey Caleb,
> > 
> > On Wed, May 24, 2023 at 06:38:52PM +0100, Caleb Connolly wrote:
> >> Document the new pmi8998 charger bindings
> > 
> > This commit message looks a bit odd compared to the contents of the
> > diff. Did you forget to git add something?
> 
> Well, it's not my finest commit message... The binding is in the series
> linked in the cover letter (or [1]), I missed this addition when sending
> that.

Ya know, I opened the cover to check if there was something more
specific said about this & somehow did not notice it. I guess the commit
message & the bot report from Rob addled my brain. Sorry about that.

> Would it be better to just squash this patch into the bindings and
> respin the other series?

I dunno chief. I am always loathe to tell people how they should submit
stuff in these kind of scenarios, as I don't wanna send them up the
garden path. But, that said, if they don't go via the same tree you're
gonna end up creating the issue that the bot reported in whatever tree
applies this patch without the other. ¯\_(ツ)_/¯

Cheers,
Conor

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]