From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org, soc@kernel.org,
William Zhang <william.zhang@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH 1/2] arm64: dts: broadcom: Enable device-tree overlay support for RPi devices
Date: Thu, 25 May 2023 09:36:41 +0200 [thread overview]
Message-ID: <20230525073641.macyt5h6uiylbytb@pengutronix.de> (raw)
In-Reply-To: <20220410225940.135744-2-aurelien@aurel32.net>
[-- Attachment #1: Type: text/plain, Size: 2339 bytes --]
Hello,
[expanded Cc: to include William Zhang and Florian Fainelli]
On Mon, Apr 11, 2022 at 12:59:39AM +0200, Aurelien Jarno wrote:
> Add the '-@' DTC option for the Raspberry Pi devices. This option
> populates the '__symbols__' node that contains all the necessary symbols
> for supporting device-tree overlays (for instance from the firmware or
> the bootloader) on these devices.
>
> The Rasbperry Pi devices are well known for their GPIO header, that
> allow various "HATs" or other modules do be connected and this enables
> users to create out-of-tree device-tree overlays for these modules.
>
> Please note that this change does increase the size of the resulting DTB
> by ~40%. For example, with v5.17 increase in size is as follows:
>
> bcm2711-rpi-400.dtb 26481 -> 36830 bytes
> bcm2711-rpi-4-b.dtb 26537 -> 36886 bytes
> bcm2711-rpi-cm4-io.dtb 26426 -> 36945 bytes
> bcm2837-rpi-3-a-plus.dtb 14133 -> 19740 bytes
> bcm2837-rpi-3-b.dtb 14310 -> 20006 bytes
> bcm2837-rpi-3-b-plus.dtb 14670 -> 20474 bytes
> bcm2837-rpi-cm3-io3.dtb 13680 -> 19266 bytes
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> arch/arm64/boot/dts/broadcom/Makefile | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/Makefile b/arch/arm64/boot/dts/broadcom/Makefile
> index 5082fcd1fea5..0aa8ee2afdd5 100644
> --- a/arch/arm64/boot/dts/broadcom/Makefile
> +++ b/arch/arm64/boot/dts/broadcom/Makefile
> @@ -1,4 +1,15 @@
> # SPDX-License-Identifier: GPL-2.0
> +
> +# Enables support for device-tree overlays
> +DTC_FLAGS_bcm2711-rpi-400 := -@
> +DTC_FLAGS_bcm2711-rpi-4-b := -@
> +DTC_FLAGS_bcm2711-rpi-cm4-io := -@
> +DTC_FLAGS_bcm2837-rpi-3-a-plus := -@
> +DTC_FLAGS_bcm2837-rpi-3-b := -@
> +DTC_FLAGS_bcm2837-rpi-3-b-plus := -@
> +DTC_FLAGS_bcm2837-rpi-cm3-io3 := -@
> +DTC_FLAGS_bcm2837-rpi-zero-2-w := -@
Instead of setting these all explicitly a single
DTC_FLAGS := -@
would work, too, without changing how the dts in subdirs are compiled.
IMHO this would be suiteable for arch/arm64/boot/dts/broadcom.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-25 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 22:59 [PATCH 0/2] arm/arm64: dts: Enable device-tree overlay support for RPi devices Aurelien Jarno
2022-04-10 22:59 ` [PATCH 1/2] arm64: dts: broadcom: " Aurelien Jarno
2023-05-25 7:36 ` Uwe Kleine-König [this message]
2022-04-10 22:59 ` [PATCH 2/2] arm: dts: " Aurelien Jarno
2023-05-22 6:22 ` [PATCH 0/2] arm/arm64: " Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2023-05-30 17:56 [PATCH 0/2] arm*/dts: Enable symbols for rpi device trees Uwe Kleine-König
2023-05-30 17:56 ` [PATCH 1/2] arm64: dts: broadcom: Enable device-tree overlay support for RPi devices Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525073641.macyt5h6uiylbytb@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=aurelien@aurel32.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).