From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA669C7EE31 for ; Fri, 26 May 2023 12:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242713AbjEZMjE (ORCPT ); Fri, 26 May 2023 08:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231209AbjEZMjE (ORCPT ); Fri, 26 May 2023 08:39:04 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99B9B116; Fri, 26 May 2023 05:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685104742; x=1716640742; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0eDJx4cPwsq80iImTB8nLrKWaWeH8p+wAFaX0YpCUpY=; b=kIUIswIV8nfMoxQbefA8Gt+/iF04dDbz6AMUzWiD0g9mpzpd3vQEDOuL woVibj7F8knInITZaEu/Hhkp/ShgHcu5FtvKCRu6t43StUX8pnGuNhjcY Ar1efd+NqLmquQwh4XVBw/m7qm27tpaAYQfzQzRpTlYJrEVuTyNGfx9ZK nnnyftnO2xstO4b2LZ/VixflGYnTZdPMi/I/q1bBzbzNoCKGS1iXGIhUd K/Di5bQirhzbjYkZaa4OlceNwJZY5zniNcDQdjZ6koilDUXi4hn6RpwNm PShGBJcqn5bXbDPBHN2+jKQSbKGw4AuiM7cTfuXUnppW2AXUSCFwFe4pA Q==; X-IronPort-AV: E=Sophos;i="6.00,194,1681196400"; d="asc'?scan'208";a="154091159" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 26 May 2023 05:39:01 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 26 May 2023 05:38:55 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 26 May 2023 05:38:52 -0700 Date: Fri, 26 May 2023 13:38:29 +0100 From: Conor Dooley To: Jiaxun Yang CC: Binbin Zhou , Conor Dooley , Binbin Zhou , Alessandro Zummo , Alexandre Belloni , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , Huacai Chen , Huacai Chen , Xuerui Wang , , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , Kelvin Cheung , zhao zhang , Yang Ling , Subject: Re: [PATCH V4 1/5] dt-bindings: rtc: Remove the LS2X from the trivial RTCs Message-ID: <20230526-hardwired-flashbulb-de3ef456f9a0@wendy> References: <9a2fbd6860f37760ca6089c150fd6f67628405f6.1684983279.git.zhoubinbin@loongson.cn> <20230525-custody-oversleep-f778eddf981c@spud> <20230526-dolly-reheat-06c4d5658415@wendy> <1EAC8FA8-4125-4436-9EE1-13B61B5687AF@flygoat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WSYevugeXVX6hZ2M" Content-Disposition: inline In-Reply-To: <1EAC8FA8-4125-4436-9EE1-13B61B5687AF@flygoat.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --WSYevugeXVX6hZ2M Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 26, 2023 at 01:22:15PM +0100, Jiaxun Yang wrote: >=20 >=20 > > 2023=E5=B9=B45=E6=9C=8826=E6=97=A5 13:06=EF=BC=8CConor Dooley =E5=86=99=E9=81=93=EF=BC=9A > Hi all, >=20 > [...] > My two cents here as Loongson64 maintainer. >=20 > >=20 > >>> To maintain compatibility with the existing devicetrees, should the o= ld > >>> "loongson,ls2x-rtc" be kept in the driver? > >>=20 > >> No, It seems that wildcards in compatible are not allowed." > >> loongson,ls2x-rtc" itself was part of this patch series at one time, > >> but apparently it is not the right way to describe these chips. > >=20 > > Right, but it has been merged - you are deleting the driver that suppor= ts > > it after all - which means that any dtb with the old compatible will > > stop working. > It is perfectly fine to break DTB compatibility for Loongson64 systems > As they *only* use builtin dtb. Bootloader will only pass machine type in= formation > and kernel will choose one dtb from it=E2=80=99s dtbs pool. Ah, that is good to know thanks! I think that should be mentioned in the commit messages for the next revision. Cheers, Conor. --WSYevugeXVX6hZ2M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHCoRQAKCRB4tDGHoIJi 0m7HAQDegOrEFQvfjtNlpAP88Pr1kQ6xFHXGlHvSieXoat9fSAD/fQLNWWmCM9oI Nebcr7/ygJ6fD/4udFPchcokkg67nA8= =4uhD -----END PGP SIGNATURE----- --WSYevugeXVX6hZ2M--