From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Georgi Djakov <djakov@kernel.org>, Leo Yan <leo.yan@linaro.org>,
Evan Green <evgreen@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: [PATCH v5 21/22] interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req
Date: Wed, 14 Jun 2023 12:22:32 +0200 [thread overview]
Message-ID: <20230526-topic-smd_icc-v5-21-eeaa09d0082e@linaro.org> (raw)
In-Reply-To: <20230526-topic-smd_icc-v5-0-eeaa09d0082e@linaro.org>
Currently, we're setting the aggregated-on-provider bandwidth on each
node, individually. That is of course incorrect and results in far too
high votes. Use the correct values to ensure we're not wasting power.
Fixes: 30c8fa3ec61a ("interconnect: qcom: Add MSM8916 interconnect provider driver")
Reported-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/interconnect/qcom/icc-rpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
index ac84fe0bc852..b7e0dfbdd26d 100644
--- a/drivers/interconnect/qcom/icc-rpm.c
+++ b/drivers/interconnect/qcom/icc-rpm.c
@@ -355,12 +355,12 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg);
- ret = qcom_icc_rpm_set(src_qn, agg_avg);
+ ret = qcom_icc_rpm_set(src_qn, src_qn->sum_avg);
if (ret)
return ret;
if (dst_qn) {
- ret = qcom_icc_rpm_set(dst_qn, agg_avg);
+ ret = qcom_icc_rpm_set(dst_qn, dst_qn->sum_avg);
if (ret)
return ret;
}
--
2.41.0
next prev parent reply other threads:[~2023-06-14 10:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:22 [PATCH v5 00/22] Restructure RPM SMD ICC Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings Konrad Dybcio
2023-06-14 16:43 ` Krzysztof Kozlowski
2023-06-14 16:43 ` Konrad Dybcio
2023-06-14 16:47 ` Krzysztof Kozlowski
2023-06-14 16:48 ` Konrad Dybcio
2023-06-14 16:52 ` Krzysztof Kozlowski
2023-06-14 16:52 ` Krzysztof Kozlowski
2023-06-14 10:22 ` [PATCH v5 02/22] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 03/22] soc: qcom: smd-rpm: Use tabs for defines Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 04/22] clk: qcom: smd-rpm: Move some RPM resources to the common header Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 05/22] soc: qcom: smd-rpm: Move icc_smd_rpm registration to clk-smd-rpm Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 06/22] interconnect: qcom: icc-rpm: Introduce keep_alive Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 07/22] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 08/22] interconnect: qcom: smd-rpm: Add rpmcc handling skeleton code Konrad Dybcio
2023-06-14 14:47 ` Stephan Gerhold
2023-06-14 17:40 ` Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 09/22] interconnect: qcom: Add missing headers in icc-rpm.h Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 10/22] interconnect: qcom: Define RPM bus clocks Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 11/22] interconnect: qcom: sdm660: Hook up RPM bus clk definitions Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 12/22] interconnect: qcom: msm8996: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 13/22] interconnect: qcom: qcs404: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 14/22] interconnect: qcom: msm8939: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 15/22] interconnect: qcom: msm8916: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 16/22] interconnect: qcom: qcm2290: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 17/22] interconnect: qcom: icc-rpm: Control bus rpmcc from icc Konrad Dybcio
2023-06-14 14:49 ` Stephan Gerhold
2023-06-14 10:22 ` [PATCH v5 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 19/22] interconnect: qcom: icc-rpm: Fix bucket number Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 20/22] interconnect: qcom: icc-rpm: Set bandwidth on both contexts Konrad Dybcio
2023-06-14 10:22 ` Konrad Dybcio [this message]
2023-06-14 10:22 ` [PATCH v5 22/22] interconnect: qcom: icc-rpm: Fix bandwidth calculations Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526-topic-smd_icc-v5-21-eeaa09d0082e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=evgreen@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).