Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, broonie@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 3/3] ARM: dts: imx6ul-ccimx6ulsom: Remove unexisting PMIC supply
Date: Sat, 27 May 2023 21:12:52 +0100	[thread overview]
Message-ID: <20230527-shakily-marrow-b18e2ac3a467@spud> (raw)
In-Reply-To: <20230527195005.398815-3-festevam@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

Hey Fabio,

On Sat, May 27, 2023 at 04:50:05PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> There is no "vcoin" supply output provided by the PFUZE100 PMIC.
> 
> Remove it to fix the following DT check warning:
> 
> imx6ul-ccimx6ulsbcexpress.dtb: pmic@8: regulators: 'vcoin' does not match any of the regexes:

Dumb question, did you spot this only because of dtbs_check, or is this
something you know to be true?
I had the datasheet open to check the interrupt thing, so I figured I
may as well look for coin cell chargers too.
Seemly there is a "licell" pin that is an input/output. Is this what the
vcoin_chg was referring to, or is that something else entirely?

I know nothing about the hardware at all, so was just something that
piqued my curiosity.

Thanks,
Conor.

> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi
> index b5781c3656d1..fe82f0b6bbda 100644
> --- a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi
> @@ -157,11 +157,6 @@ ldo4_ext: vldo4 {
>  				regulator-min-microvolt = <1800000>;
>  				regulator-max-microvolt = <3300000>;
>  			};
> -
> -			vcoin_chg: vcoin {
> -				regulator-min-microvolt = <2500000>;
> -				regulator-max-microvolt = <3300000>;
> -			};
>  		};
>  	};
>  };
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-05-27 20:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27 19:50 [PATCH 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Fabio Estevam
2023-05-27 19:50 ` [PATCH 2/3] ARM: dts: imx: Use 'pmic' as node name Fabio Estevam
2023-05-27 19:50 ` [PATCH 3/3] ARM: dts: imx6ul-ccimx6ulsom: Remove unexisting PMIC supply Fabio Estevam
2023-05-27 20:12   ` Conor Dooley [this message]
2023-05-27 20:32     ` Fabio Estevam
2023-05-27 20:06 ` [PATCH 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230527-shakily-marrow-b18e2ac3a467@spud \
    --to=conor@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox