Re: [PATCH 1/2] ARM: dts: imx7d-sdb: Describe the SD card regulator

[Shawn Guo <shawnguo@kernel.org>]

On Thu, May 18, 2023 at 06:54:46PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Improve the devicetree description by adding the SD card regulator
> that is controlled via GPIO5_2.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/imx7d-sdb.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index 25681c430393..6e45f1154611 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -60,6 +60,17 @@ extended_io: gpio-expander@0 {
>  		};
>  	};
>  
> +	reg_sd1_vmmc: regulator-sd1-vmmc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VDD_SD1";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
> +		startup-delay-us = <200000>;
> +		off-on-delay-us = <20000>;
> +		enable-active-high;

Can we put this right after 'gpio'?

Shawn

> +	};
> +
>  	reg_usb_otg1_vbus: regulator-usb-otg1-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "usb_otg1_vbus";
> @@ -477,6 +488,7 @@ &usdhc1 {
>  	pinctrl-0 = <&pinctrl_usdhc1>;
>  	cd-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>;
>  	wp-gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>;
> +	vmmc-supply = <&reg_sd1_vmmc>;
>  	wakeup-source;
>  	keep-power-in-suspend;
>  	status = "okay";
> -- 
> 2.34.1
>