From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: imx8mn-beacon: Migrate sound card to simple-audio-card
Date: Sat, 27 May 2023 20:32:31 +0800 [thread overview]
Message-ID: <20230527123231.GS528183@dragon> (raw)
In-Reply-To: <20230521231055.167351-1-aford173@gmail.com>
On Sun, May 21, 2023 at 06:10:54PM -0500, Adam Ford wrote:
> Instead of using a custom glue layer connecting the wm8962 CODEC
> to the SAI3 sound-dai, migrate the sound card to simple-audio-card.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Can you double check both patches? The changes do not seem to match
subject and commit log.
Shawn
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index bd84db550053..8be8f090e8b8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -1069,13 +1069,6 @@ lcdif: lcdif@32e00000 {
> <&clk IMX8MN_CLK_DISP_APB_ROOT>,
> <&clk IMX8MN_CLK_DISP_AXI_ROOT>;
> clock-names = "pix", "axi", "disp_axi";
> - assigned-clocks = <&clk IMX8MN_CLK_DISP_PIXEL_ROOT>,
> - <&clk IMX8MN_CLK_DISP_AXI>,
> - <&clk IMX8MN_CLK_DISP_APB>;
> - assigned-clock-parents = <&clk IMX8MN_CLK_DISP_PIXEL>,
> - <&clk IMX8MN_SYS_PLL2_1000M>,
> - <&clk IMX8MN_SYS_PLL1_800M>;
> - assigned-clock-rates = <594000000>, <500000000>, <200000000>;
> interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_LCDIF>;
> status = "disabled";
> @@ -1093,12 +1086,6 @@ mipi_dsi: dsi@32e10000 {
> clocks = <&clk IMX8MN_CLK_DSI_CORE>,
> <&clk IMX8MN_CLK_DSI_PHY_REF>;
> clock-names = "bus_clk", "sclk_mipi";
> - assigned-clocks = <&clk IMX8MN_CLK_DSI_CORE>,
> - <&clk IMX8MN_CLK_DSI_PHY_REF>;
> - assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_266M>,
> - <&clk IMX8MN_CLK_24M>;
> - assigned-clock-rates = <266000000>, <24000000>;
> - samsung,pll-clock-frequency = <24000000>;
> interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&disp_blk_ctrl IMX8MN_DISPBLK_PD_MIPI_DSI>;
> status = "disabled";
> @@ -1142,6 +1129,21 @@ disp_blk_ctrl: blk-ctrl@32e28000 {
> "lcdif-axi", "lcdif-apb", "lcdif-pix",
> "dsi-pclk", "dsi-ref",
> "csi-aclk", "csi-pclk";
> + assigned-clocks = <&clk IMX8MN_CLK_DSI_CORE>,
> + <&clk IMX8MN_CLK_DSI_PHY_REF>,
> + <&clk IMX8MN_CLK_DISP_PIXEL>,
> + <&clk IMX8MN_CLK_DISP_AXI>,
> + <&clk IMX8MN_CLK_DISP_APB>;
> + assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_266M>,
> + <&clk IMX8MN_CLK_24M>,
> + <&clk IMX8MN_VIDEO_PLL1_OUT>,
> + <&clk IMX8MN_SYS_PLL2_1000M>,
> + <&clk IMX8MN_SYS_PLL1_800M>;
> + assigned-clock-rates = <266000000>,
> + <24000000>,
> + <594000000>,
> + <500000000>,
> + <200000000>;
> #power-domain-cells = <1>;
> };
>
> --
> 2.39.2
>
prev parent reply other threads:[~2023-05-27 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 23:10 [PATCH 1/2] arm64: dts: imx8mn-beacon: Migrate sound card to simple-audio-card Adam Ford
2023-05-21 23:10 ` [PATCH 2/2] arm64: dts: imx8mn-beacon: Fix SPI CS pinmux Adam Ford
2023-05-27 12:32 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230527123231.GS528183@dragon \
--to=shawnguo@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).