From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6C3C77B7C for ; Sun, 28 May 2023 17:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjE1RWk (ORCPT ); Sun, 28 May 2023 13:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjE1RWj (ORCPT ); Sun, 28 May 2023 13:22:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C03B2; Sun, 28 May 2023 10:22:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 961E660EBC; Sun, 28 May 2023 17:22:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14F97C433EF; Sun, 28 May 2023 17:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685294558; bh=a0bn35byPravsJL/aYIpPMkp2CEo3YyQfJm8G1Uhmj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JcSvyNHSuJhMCIZhkT0NmgEV5yatXQOX99p2xnzxjucNbNZ6i+BarPWm+13xPevVd KnycU6jKzIlvm7c2h7mYTACvih4blk1JQl65IJZfKFy9lzQDMiWBd9fp6RMx+4sZEG ibDQ0gagPYT7jefM+FoWANzeB8YfacbrZ6le8iCjeL13sJyotz6bySx47Um43dQ9G3 bwo2hN2kWqgdJTsdpjEHJszC3HNRRx7MtHXZPm8Kuhj+8llDq9h56E4lsVZ6p0atQA FzK0m/L8lOLn9PUhYRNtOciGzh5XjkBGF/zDc5GE6A52LX5sxmDOsGCALfgjU6O8xY IzaFvxx+p9pXg== Date: Sun, 28 May 2023 18:38:55 +0100 From: Jonathan Cameron To: Herve Codina Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lars-Peter Clausen , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v2 7/9] ASoC: codecs: Add support for the generic IIO auxiliary devices Message-ID: <20230528183855.0c95d308@jic23-huawei> In-Reply-To: <20230523151223.109551-8-herve.codina@bootlin.com> References: <20230523151223.109551-1-herve.codina@bootlin.com> <20230523151223.109551-8-herve.codina@bootlin.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 23 May 2023 17:12:21 +0200 Herve Codina wrote: > Industrial I/O devices can be present in the audio path. > These devices needs to be used as audio components in order to be fully > integrated in the audio path. > > This support allows to consider these Industrial I/O devices as auxliary > audio devices and allows to control them using mixer controls. > > Signed-off-by: Herve Codina > --- > diff --git a/sound/soc/codecs/audio-iio-aux.c b/sound/soc/codecs/audio-iio-aux.c > new file mode 100644 > index 000000000000..21575c4b35fd > --- /dev/null > +++ b/sound/soc/codecs/audio-iio-aux.c > @@ -0,0 +1,302 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// audio-iio-aux.c -- ALSA SoC glue to use IIO devices as audio components > +// > +// Copyright 2023 CS GROUP France > +// > +// Author: Herve Codina > + > +#include > +#include #include ideally to pick up the of_device_id definition without bouncing through some non obvious header path. > +#include > +#include > +#include Otherwise, the IIO elements of this look good. So for those at least Reviewed-by: Jonathan Cameron I don't have enough knowledge of the snd stuff to review those parts. Jonathan