From: Conor Dooley <conor@kernel.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v4 6/9] dt-bindings: sc16is7xx: Add property to change GPIO function
Date: Mon, 29 May 2023 19:09:39 +0100 [thread overview]
Message-ID: <20230529-florist-hardiness-be5de59e660c@spud> (raw)
In-Reply-To: <20230529102601.144e17eccefaedc891e76f3a@hugovil.com>
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
On Mon, May 29, 2023 at 10:26:01AM -0400, Hugo Villeneuve wrote:
> On Mon, 29 May 2023 15:16:47 +0100
> Conor Dooley <conor.dooley@microchip.com> wrote:
>
> > Hey Hugo,
> >
> > On Mon, May 29, 2023 at 10:07:08AM -0400, Hugo Villeneuve wrote:
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >
> > > Some variants in this series of UART controllers have GPIO pins that
> > > are shared between GPIO and modem control lines.
> > >
> > > The pin mux mode (GPIO or modem control lines) can be set for each
> > > ports (channels) supported by the variant.
> > >
> > > This adds a property to the device tree to set the GPIO pin mux to
> > > modem control lines on selected ports if needed.
> > >
> > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > Did I not ack this in v2? I didn't notice a reason for dropping it
> > in the cover etc. Was it intentionally dropped, or missed?
> In v3, I slighly modified the example, and that is why I didn't copy your ack.
Ah, I would say that for "slight modifications" when you have an ack,
you could keep it - but everyone is different and dropping tags is
likely to piss people off less than keeping them, so I understand
sticking on the safe side.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-29 18:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 14:07 [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 1/9] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 2/9] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 3/9] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 4/9] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 5/9] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 6/9] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-05-29 14:16 ` Conor Dooley
2023-05-29 14:26 ` Hugo Villeneuve
2023-05-29 18:09 ` Conor Dooley [this message]
2023-05-29 18:19 ` Conor Dooley
2023-05-29 18:33 ` Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 7/9] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-05-29 16:10 ` Ilpo Järvinen
2023-05-29 22:38 ` andy.shevchenko
2023-05-30 15:36 ` Hugo Villeneuve
2023-05-30 21:56 ` Andy Shevchenko
2023-05-31 13:57 ` Hugo Villeneuve
2023-05-31 23:57 ` Hugo Villeneuve
2023-06-01 9:24 ` Andy Shevchenko
2023-05-30 10:25 ` Greg KH
2023-05-30 16:25 ` Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 8/9] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 9/9] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-05-29 22:31 ` [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements andy.shevchenko
2023-05-30 2:07 ` Hugo Villeneuve
2023-05-30 11:15 ` andy.shevchenko
2023-05-30 15:41 ` Hugo Villeneuve
2023-05-29 22:40 ` andy.shevchenko
2023-05-30 9:30 ` Lech Perczak
2023-05-30 13:08 ` Hugo Villeneuve
2023-05-31 10:43 ` Lech Perczak
2023-05-31 13:56 ` Hugo Villeneuve
2023-05-31 15:00 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529-florist-hardiness-be5de59e660c@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox