From: Conor Dooley <conor@kernel.org>
To: Stanley Chang <stanley_chang@realtek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Flavio Suligoi <f.suligoi@asem.it>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>, Ray Chi <raychi@google.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0/3.0 PHY
Date: Mon, 29 May 2023 19:59:22 +0100 [thread overview]
Message-ID: <20230529-impurity-dismount-bca5c9100c9b@spud> (raw)
In-Reply-To: <20230525022617.30537-3-stanley_chang@realtek.com>
[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]
Hey,
On Thu, May 25, 2023 at 10:26:04AM +0800, Stanley Chang wrote:
> +properties:
> + compatible:
> + enum:
> + - realtek,usb2phy
> + - realtek,rtd-usb2phy
> + - realtek,rtd1295-usb2phy
> + - realtek,rtd1395-usb2phy
> + - realtek,rtd1619-usb2phy
> + - realtek,rtd1319-usb2phy
> + - realtek,rtd1619b-usb2phy
> + - realtek,rtd1312c-usb2phy
> + - realtek,rtd1319d-usb2phy
> + - realtek,rtd1315e-usb2phy
> +properties:
> + compatible:
> + enum:
> + - realtek,usb3phy
> + - realtek,rtd-usb3phy
> + - realtek,rtd1295-usb3phy
> + - realtek,rtd1619-usb3phy
> + - realtek,rtd1319-usb3phy
> + - realtek,rtd1619b-usb3phy
> + - realtek,rtd1319d-usb3phy
Ignoring everything else, because I really want Krzysztof or Rob to
review this rather than me, but what's going on here with the
compatibles?
What hardware do "usbNphy" and "rtd-usbNphy" represent?
You have device-specific compatibles, which is great, but you also allow
only those two generic ones. I had a _brief_ look at the driver, and it
seems like there is no decision making done based on the compatibles,
only on the properties. Is that correct?
If it is, I would understand having "realtek,usb3phy" as a fallback
compatible for "realtek,rtd1619-usb3phy", but I do not get the current
setup.
Also, I really think this should be broken down into two patches, one
for each of USB 2 & 3.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-05-29 18:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 2:26 [PATCH v2 1/3] usb: phy: add usb phy notify port status API Stanley Chang
2023-05-25 2:26 ` [PATCH v2 2/3] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0/3.0 PHY Stanley Chang
2023-05-29 14:25 ` Greg Kroah-Hartman
2023-05-30 1:50 ` Stanley Chang[昌育德]
2023-05-30 7:31 ` Greg Kroah-Hartman
2023-05-30 7:37 ` Stanley Chang[昌育德]
2023-05-25 2:26 ` [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about " Stanley Chang
2023-05-29 18:59 ` Conor Dooley [this message]
2023-05-30 3:08 ` Stanley Chang[昌育德]
2023-05-30 6:56 ` Conor Dooley
[not found] ` <202305310146.34V1kevI7026106@rtits1.realtek.com.tw>
2023-06-01 2:24 ` Stanley Chang[昌育德]
2023-06-01 20:13 ` Conor Dooley
[not found] ` <0b2143ca-ead7-c8fa-2e80-a94222af51ca@linaro.org>
2023-06-01 10:49 ` Stanley Chang[昌育德]
2023-06-01 15:32 ` Krzysztof Kozlowski
2023-06-02 3:20 ` Stanley Chang[昌育德]
2023-06-02 7:10 ` Krzysztof Kozlowski
2023-06-02 7:33 ` Stanley Chang[昌育德]
2023-05-29 14:27 ` [PATCH v2 1/3] usb: phy: add usb phy notify port status API Greg Kroah-Hartman
2023-05-30 2:19 ` Stanley Chang[昌育德]
2023-05-30 7:32 ` Greg Kroah-Hartman
2023-05-30 7:38 ` Stanley Chang[昌育德]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529-impurity-dismount-bca5c9100c9b@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox