From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFA6C7EE29 for ; Tue, 30 May 2023 02:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbjE3CIG (ORCPT ); Mon, 29 May 2023 22:08:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbjE3CIF (ORCPT ); Mon, 29 May 2023 22:08:05 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB4EF131; Mon, 29 May 2023 19:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8b7axy2ugwNnYpSJ0ufdxmI8eLFv3CFyiX/N3qWXuJ8=; b=tfvBCuK4DDooO23JHHoy0i7lZ6 rIdQLSmZMncYs7N3rUt8W9Y9e+Vr7JZkGzKEnlZVhaqIMBA6zZQH7YV0CrWQqn0q8Q0DYObTsSkQ5 ECmUM8Y9UihOYWqKPkHSLvL1RaGq7Zcn46wQb/a0mAn5cc0C6RBD6lK63y8/dMRPGxIg=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:59646 helo=debian-acer) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1q3olR-0002Pe-83; Mon, 29 May 2023 22:07:09 -0400 Date: Mon, 29 May 2023 22:07:08 -0400 From: Hugo Villeneuve To: andy.shevchenko@gmail.com Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve Message-Id: <20230529220708.66f7825fed9ee36b181128cf@hugovil.com> In-Reply-To: References: <20230529140711.896830-1-hugo@hugovil.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 30 May 2023 01:31:28 +0300 andy.shevchenko@gmail.com wrote: > Mon, May 29, 2023 at 10:07:02AM -0400, Hugo Villeneuve kirjoitti: > > From: Hugo Villeneuve > > > > Hello, > > this patch series mainly fixes a GPIO regression and improve RS485 flags and > > properties detection from DT. > > > > It now also includes various small fixes and improvements that were previously > > sent as separate patches, but that made testing everything difficult. > > > > Patch 1 fixes an issue when debugging IOcontrol register. After testing the GPIO > > regression patches (patches 6 and 7, tests done by Lech Perczak), it appers that > > this patch is also necessary for having the correct IOcontrol register values. > > > > Patch 2 introduces a delay after a reset operation to respect datasheet > > timing recommandations. > > These two patches are w/o Fixes tag, they should be moved in the series further > as I explained before. Your explanation was not clear. Anyway, I moved them in position 7 and 8. > > Patch 3 fixes an issue with init of first port during probing. > > > > Patch 4 fixes a bug with the output value when first setting the GPIO direction. > > > > Patch 5 is a refactor of GPIO registration code. > > > > Patches 6 and 7 fix a GPIO regression by (re)allowing to choose GPIO function > > for GPIO pins shared with modem status lines. > > > > Patch 8 allows to read common rs485 device-tree flags and properties. > > > > Patch 9 improves comments about chip variants. > > > > I have tested the changes on a custom board with two SC16IS752 DUART using a > > Variscite IMX8MN NANO SOM. > > -- > With Best Regards, > Andy Shevchenko