From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8A1C7EE23 for ; Tue, 30 May 2023 14:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230515AbjE3ONa (ORCPT ); Tue, 30 May 2023 10:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbjE3ON2 (ORCPT ); Tue, 30 May 2023 10:13:28 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72BDA1A8; Tue, 30 May 2023 07:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1685455971; x=1716991971; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WEVu+mlvG0A1jNh0gMO3FS1zwOln0/CKg69F1Wt0HZ4=; b=uSI2073EMpI6UpRAYMz/GdViDIDiTvwHYHPPp8W00IPxMqU3UjRM8ul1 haZksZhJckEHnneTFjwlSDPFoym5+fG0dX6g39FM51Wy6Ydr6ZgEefByZ 4yDGhAPDNEJuEKxE7pXZitaWp9/W5DMs8XX04Ziq5JTsr4pYcqdBgOnqy H2jM9vgIOHcmKaCBcBJa7TK2Sr8rzN8hs3yc3nTpNFCzyBnO2Mz+xN5NY p2qs3YU9+/S1WyfF+fzm+e8MmTIicgh5p3SXhsymHmt8xrFUlp6/qP9q6 +TcpIoGdOLu2zYBIAsuDuyXBLDIVvMaCvHODvmyVuKLVi69HE+S7Ojwqx A==; X-IronPort-AV: E=Sophos;i="6.00,204,1681196400"; d="asc'?scan'208";a="213732970" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 May 2023 07:12:41 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 30 May 2023 07:12:38 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 30 May 2023 07:12:35 -0700 Date: Tue, 30 May 2023 15:12:12 +0100 From: Conor Dooley To: Conor Dooley CC: Sean Anderson , Anup Patel , Andrew Jones , , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Alistair Francis , Anup Patel , Atish Patra , Jessica Clarke , Rick Chen , Leo , , , , , Subject: Re: [PATCH v1] dt-bindings: riscv: deprecate riscv,isa Message-ID: <20230530-duller-reset-a34ae111f207@wendy> References: <20230518-thermos-sanitary-cf3fbc777ea1@wendy> <20230518-4050231ca8dbe93c08cf9c9a@orel> <20230518-hammock-doornail-478e8ea8e6a7@wendy> <20230518-monkhood-dispersal-6749b1228b0d@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ljjWyKcHLn9dJQRC" Content-Disposition: inline In-Reply-To: <20230518-monkhood-dispersal-6749b1228b0d@spud> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --ljjWyKcHLn9dJQRC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 18, 2023 at 10:42:34PM +0100, Conor Dooley wrote: > On Thu, May 18, 2023 at 02:30:53PM -0400, Sean Anderson wrote: > >=20 > > Why not just have something like > >=20 > > mycpu { > > ... > > riscv,isa { > > i; > > m; > > a; > > zicsr; > > ... > > }; > > }; > > Naming of the node aside (perhaps that could be riscv,isa-extensions) > there's not something hitting me immediately as to why that is a no-no. > If the size is a concern, this would certainly be more efficient & not > like the probing would be anything other than trivial more difficult > what I have in my proposal. Having started messing around with this, one of the main advantages, to me, of this approach is proper validation. cpus.yaml has additionalProperties: true in it, which would have had to be sorted out, or worked around, but creating a child-node with the properties in it allows setting additionalProperties: false. > Rob's AFK at the moment, and I was hoping that he would take a look at > the idea, so I won't respin til he is back, but I'll give this a go in > the interim. Mechanically, the conversion of the patch isn't difficult, but I'll still wait for Rob to come back before sending a v2. But that v2 will more than likely implement your suggestion. Cheers, Conor. --ljjWyKcHLn9dJQRC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHYEPAAKCRB4tDGHoIJi 0gU0AQC4+rB11CsvWYlWy1TRnq5jU9IikN+9XHIPda7SYYnZMQEAo6jPRTwwWFo7 hJxgKpYYRrcYOdotg5wYkneWq4yBCQs= =BG8u -----END PGP SIGNATURE----- --ljjWyKcHLn9dJQRC--