From: Stephan Gerhold <stephan@gerhold.net>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: [PATCH 5/8] arm64: dts: qcom: msm8939: Fix regulator constraints
Date: Wed, 14 Jun 2023 09:16:03 +0200 [thread overview]
Message-ID: <20230530-msm8939-regulators-v1-5-a3c3ac833567@gerhold.net> (raw)
In-Reply-To: <20230530-msm8939-regulators-v1-0-a3c3ac833567@gerhold.net>
The regulator constraints for the MSM8939 devices were originally taken
from Qualcomm's msm-3.10 vendor device tree (for lack of better
documentation). Unfortunately it turns out that Qualcomm's voltages are
slightly off as well and do not match the voltage constraints applied
by the RPM firmware.
This means that we sometimes request a specific voltage but the RPM
firmware actually applies a much lower or higher voltage. This is
particularly critical for pm8916_l11 which is used as SD card VMMC
regulator: The SD card can choose a voltage from the current range of
1.8 - 2.95V. If it chooses to run at 1.8V we pretend that this is fine
but the RPM firmware will still silently end up configuring 2.95V.
This can be easily reproduced with a multimeter or by checking the
SPMI hardware registers of the regulator.
Apply the same change as for MSM8916 in commit 355750828c55 ("arm64:
dts: qcom: msm8916: Fix regulator constraints") and make the voltages
match the actual "specified range" in the PM8916 Device Specification
which is enforced by the RPM firmware.
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
arch/arm64/boot/dts/qcom/apq8039-t2.dts | 12 ++++++------
.../arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts | 12 ++++++------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8039-t2.dts b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
index c8442242137a..ceae83b1480b 100644
--- a/arch/arm64/boot/dts/qcom/apq8039-t2.dts
+++ b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
@@ -164,13 +164,13 @@ &smd_rpm_regulators {
vdd_l7-supply = <&pm8916_s4>;
pm8916_s3: s3 {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1300000>;
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <1350000>;
};
pm8916_s4: s4 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <2100000>;
+ regulator-min-microvolt = <1850000>;
+ regulator-max-microvolt = <2150000>;
};
/* l1 is fixed to 1225000, but not connected in schematic */
@@ -201,7 +201,7 @@ pm8916_l7: l7 {
};
pm8916_l8: l8 {
- regulator-min-microvolt = <2850000>;
+ regulator-min-microvolt = <2900000>;
regulator-max-microvolt = <2900000>;
};
@@ -216,7 +216,7 @@ pm8916_l10: l10 {
};
pm8916_l11: l11 {
- regulator-min-microvolt = <1800000>;
+ regulator-min-microvolt = <2950000>;
regulator-max-microvolt = <2950000>;
};
diff --git a/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts b/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts
index 509abcdad287..2905dd8d4bf9 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts
@@ -64,13 +64,13 @@ &smd_rpm_regulators {
vdd_l7-supply = <&pm8916_s4>;
pm8916_s3: s3 {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1300000>;
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <1350000>;
};
pm8916_s4: s4 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <2100000>;
+ regulator-min-microvolt = <1850000>;
+ regulator-max-microvolt = <2150000>;
};
pm8916_l2: l2 {
@@ -99,7 +99,7 @@ pm8916_l7: l7 {
};
pm8916_l8: l8 {
- regulator-min-microvolt = <2850000>;
+ regulator-min-microvolt = <2900000>;
regulator-max-microvolt = <2900000>;
};
@@ -114,7 +114,7 @@ pm8916_l10: l10 {
};
pm8916_l11: l11 {
- regulator-min-microvolt = <1800000>;
+ regulator-min-microvolt = <2950000>;
regulator-max-microvolt = <2950000>;
regulator-system-load = <200000>;
regulator-allow-set-load;
--
2.40.1
next prev parent reply other threads:[~2023-06-14 7:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 7:15 [PATCH 0/8] arm64: dts: qcom: msm8939: Rework regulator constraints Stephan Gerhold
2023-06-14 7:15 ` [PATCH 1/8] arm64: dts: qcom: msm8939-pm8916: Add missing pm8916_codec supplies Stephan Gerhold
2023-06-14 12:23 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 2/8] arm64: dts: qcom: msm8939: Disable lpass_codec by default Stephan Gerhold
2023-06-14 12:25 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 3/8] arm64: dts: qcom: msm8939-sony-tulip: Fix l10-l12 regulator voltages Stephan Gerhold
2023-06-14 12:26 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 4/8] arm64: dts: qcom: msm8939-sony-tulip: Allow disabling pm8916_l6 Stephan Gerhold
2023-06-14 12:26 ` Bryan O'Donoghue
2023-06-14 7:16 ` Stephan Gerhold [this message]
2023-06-14 12:48 ` [PATCH 5/8] arm64: dts: qcom: msm8939: Fix regulator constraints Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 6/8] arm64: dts: qcom: msm8939-pm8916: Clarify purpose Stephan Gerhold
2023-06-14 7:16 ` [PATCH 7/8] arm64: dts: qcom: msm8939: Define regulator constraints next to usage Stephan Gerhold
2023-06-14 12:51 ` Bryan O'Donoghue
2023-06-14 7:16 ` [PATCH 8/8] arm64: dts: qcom: msm8939-pm8916: Mark always-on regulators Stephan Gerhold
2023-06-14 16:03 ` [PATCH 0/8] arm64: dts: qcom: msm8939: Rework regulator constraints Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530-msm8939-regulators-v1-5-a3c3ac833567@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).