[PATCH net-next 2/2] net: phy: adin: add support for inverting the link status output signal

[PATCH net-next 2/2] net: phy: adin: add support for inverting the link status output signal

[Atsushi Nemoto]

The ADIN1200/ADIN1300 supports inverting the link status output signal
on the LINK_ST pin.

Add support for selecting this feature via device-tree properties.

Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
---
 drivers/net/phy/adin.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 134637584a83..331f9574328f 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -140,6 +140,9 @@
 #define ADIN1300_RMII_20_BITS			0x0004
 #define ADIN1300_RMII_24_BITS			0x0005
 
+#define ADIN1300_GE_LNK_STAT_INV_REG		0xff3c
+#define   ADIN1300_GE_LNK_STAT_INV_EN		BIT(0)
+
 /**
  * struct adin_cfg_reg_map - map a config value to aregister value
  * @cfg:	value in device configuration
@@ -495,6 +498,15 @@ static int adin_config_init(struct phy_device *phydev)
 	if (rc < 0)
 		return rc;
 
+	if (device_property_read_bool(&phydev->mdio.dev,
+				      "adi,link-stat-inv")) {
+		rc = phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+				      ADIN1300_GE_LNK_STAT_INV_REG,
+				      ADIN1300_GE_LNK_STAT_INV_EN);
+		if (rc < 0)
+			return rc;
+	}
+
 	phydev_dbg(phydev, "PHY is using mode '%s'\n",
 		   phy_modes(phydev->interface));
 
-- 
2.30.2

Re: [PATCH net-next 2/2] net: phy: adin: add support for inverting the link status output signal

[Horatiu Vultur]

The 05/30/2023 14:36, Atsushi Nemoto wrote:

Hi Atsushi,

When you create patch series that contains more than 1 patch, you need to
create also a cover letter.
Also it seems that not all the maintainers were CCed. To find out which
ones are the maintainers please use: ./scripts/get_maintainer.pl

Other than that, it looks OK.

 
> The ADIN1200/ADIN1300 supports inverting the link status output signal
> on the LINK_ST pin.
> 
> Add support for selecting this feature via device-tree properties.
> 
> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
> ---
>  drivers/net/phy/adin.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
> index 134637584a83..331f9574328f 100644
> --- a/drivers/net/phy/adin.c
> +++ b/drivers/net/phy/adin.c
> @@ -140,6 +140,9 @@
>  #define ADIN1300_RMII_20_BITS                  0x0004
>  #define ADIN1300_RMII_24_BITS                  0x0005
> 
> +#define ADIN1300_GE_LNK_STAT_INV_REG           0xff3c
> +#define   ADIN1300_GE_LNK_STAT_INV_EN          BIT(0)
> +
>  /**
>   * struct adin_cfg_reg_map - map a config value to aregister value
>   * @cfg:       value in device configuration
> @@ -495,6 +498,15 @@ static int adin_config_init(struct phy_device *phydev)
>         if (rc < 0)
>                 return rc;
> 
> +       if (device_property_read_bool(&phydev->mdio.dev,
> +                                     "adi,link-stat-inv")) {
> +               rc = phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
> +                                     ADIN1300_GE_LNK_STAT_INV_REG,
> +                                     ADIN1300_GE_LNK_STAT_INV_EN);
> +               if (rc < 0)
> +                       return rc;
> +       }
> +
>         phydev_dbg(phydev, "PHY is using mode '%s'\n",
>                    phy_modes(phydev->interface));
> 
> --
> 2.30.2
> 
> 
> 

-- 
/Horatiu

Re: [PATCH net-next 2/2] net: phy: adin: add support for inverting the link status output signal

[Atsushi Nemoto]

On 2023/05/31 15:37, Horatiu Vultur wrote:
> When you create patch series that contains more than 1 patch, you need to
> create also a cover letter.
> Also it seems that not all the maintainers were CCed. To find out which
> ones are the maintainers please use: ./scripts/get_maintainer.pl
> 
> Other than that, it looks OK.

Thank you for your review.
I just posted revised patchset.

---
Atsushi Nemoto