From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, enachman@marvell.com
Subject: Re: [PATCH v7 4/4] dt-bindings: mtd: marvell-nand: Remove deprecated compatibles
Date: Wed, 31 May 2023 09:33:26 +0200 [thread overview]
Message-ID: <20230531093326.26b6ced7@xps-13> (raw)
In-Reply-To: <20230530235456.1009082-5-chris.packham@alliedtelesis.co.nz>
Hi Chris,
chris.packham@alliedtelesis.co.nz wrote on Wed, 31 May 2023 11:54:56
+1200:
> Remove compatible values that were marked as deprecated in the old text
> binding.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> .../devicetree/bindings/mtd/marvell,nand-controller.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> index 7cd4a2e99343..80ce854291cb 100644
> --- a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> @@ -18,9 +18,6 @@ properties:
> - enum:
> - marvell,armada370-nand-controller
> - marvell,pxa3xx-nand-controller
> - - marvell,armada-8k-nand
> - - marvell,armada370-nand
> - - marvell,pxa3xx-nand
Not sure what you're doing here? I would actually expect these three
lines to have something along:
deprecated: true
and this should be part of the conversion to yaml. Or perhaps I am
missing something?
The rest of the series looks good to me.
>
> reg:
> maxItems: 1
Thanks,
Miquèl
next prev parent reply other threads:[~2023-05-31 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:54 [PATCH v7 0/4] dt-bindings: mtd: marvell-nand: Add YAML scheme Chris Packham
2023-05-30 23:54 ` [PATCH v7 1/4] arm64: dts: marvell: cp11x: Fix nand_controller node name according to YAML Chris Packham
2023-05-31 7:35 ` Miquel Raynal
2023-05-30 23:54 ` [PATCH v7 2/4] ARM: dts: mvebu: align MTD partition nodes to dtschema Chris Packham
2023-05-31 7:35 ` Miquel Raynal
2023-05-30 23:54 ` [PATCH v7 3/4] dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme Chris Packham
2023-05-31 12:35 ` Conor Dooley
2023-05-31 22:52 ` Chris Packham
2023-05-31 22:43 ` Chris Packham
2023-06-01 7:40 ` Miquel Raynal
2023-05-30 23:54 ` [PATCH v7 4/4] dt-bindings: mtd: marvell-nand: Remove deprecated compatibles Chris Packham
2023-05-31 7:33 ` Miquel Raynal [this message]
2023-05-31 22:36 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531093326.26b6ced7@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).