From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EAD3C7EE2F for ; Wed, 31 May 2023 14:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237524AbjEaOEa (ORCPT ); Wed, 31 May 2023 10:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbjEaOEC (ORCPT ); Wed, 31 May 2023 10:04:02 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E99223591; Wed, 31 May 2023 06:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bwuQspTy1mOtqYbpi42BSg/6JZzLF3aBnMaOThn2Z10=; b=JU6+bvZQs8ZNTYjsgd45XMwojo 583AIIgedzDd2EmJ3C4tHo3hE9GPl6DRZ2BhC2stWbCPB6mjHPZYiNks6C1UtHbJyBLSOrHXSBtzs cLGXckJcQmmhMsyrNuwJ+9fAS3rZ5KgRIz8DnGL47lR9uwW+/D59jtmCwIBrkGg/dVgY=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:49292 helo=debian-acer) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1q4MJ6-0000Dn-Uf; Wed, 31 May 2023 09:56:11 -0400 Date: Wed, 31 May 2023 09:56:08 -0400 From: Hugo Villeneuve To: Lech Perczak Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve Message-Id: <20230531095608.e1b4358549562b8e1bdf5cb4@hugovil.com> In-Reply-To: References: <20230529140711.896830-1-hugo@hugovil.com> <20230530090836.27b8d080d6b6c022b303ac9e@hugovil.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 31 May 2023 12:43:48 +0200 Lech Perczak wrote: > W dniu 30.05.2023 o=A015:08, Hugo Villeneuve pisze: > > On Tue, 30 May 2023 11:30:07 +0200 > > Lech Perczak wrote: > > > > > W dniu 29.05.2023 o=A016:07, Hugo Villeneuve pisze: > > > > From: Hugo Villeneuve > > > > > > > > Hello, > > > > this patch series mainly fixes a GPIO regression and improve RS485 = flags and > > > > properties detection from DT. > > > > > > > > It now also includes various small fixes and improvements that were= previously > > > > sent as separate patches, but that made testing everything difficul= t. > > > > > > > > Patch 1 fixes an issue when debugging IOcontrol register. After tes= ting the GPIO > > > > regression patches (patches 6 and 7, tests done by Lech Perczak), i= t appers that > > > > this patch is also necessary for having the correct IOcontrol regis= ter values. > > > > > > > > Patch 2 introduces a delay after a reset operation to respect datas= heet > > > > timing recommandations. > > > > > > > > Patch 3 fixes an issue with init of first port during probing. > > > > > > > > Patch 4 fixes a bug with the output value when first setting the GP= IO direction. > > > > > > > > Patch 5 is a refactor of GPIO registration code. > > > > > > > > Patches 6 and 7 fix a GPIO regression by (re)allowing to choose GPI= O function > > > > for GPIO pins shared with modem status lines. > > > > > > > > Patch 8 allows to read common rs485 device-tree flags and propertie= s. > > > > > > > > Patch 9 improves comments about chip variants. > > > > > > > > I have tested the changes on a custom board with two SC16IS752 DUAR= T using a > > > > Variscite IMX8MN NANO SOM. > > > > > > > > Thank you. > > > > > > > > Link: [v1] https://lkml.org/lkml/2023/5/17/967 > > > > > [v1] https://lkml.org/lkml/2023/5/17/777 > > > > > [v1] https://lkml.org/lkml/2023/5/17/780 > > > > > [v1] https://lkml.org/lkml/2023/5/17/785 > > > > > [v1] https://lkml.org/lkml/2023/5/17/1311 > > > > > [v2] https://lkml.org/lkml/2023/5/18/516 > > > > > [v3] https://lkml.org/lkml/2023/5/25/7 > > > > > > > > > Changes for V3: > > > > - Integrated all patches into single serie to facilitate debugging = and tests. > > > > - Reduce number of exported GPIOs depending on new property > > > > nxp,modem-control-line-ports > > > > - Added additional example in DT bindings > > > > > > > > Changes for V4: > > > > - Increase reset post delay to relax scheduler. > > > > - Put comments patches at the end. > > > > - Remove Fixes tag for patch "mark IOCONTROL register as volatile". > > > > - Improve commit messages after reviews. > > > > - Fix coding style issues after reviews. > > > > - Change GPIO registration to always register the maximum number of= GPIOs > > > > supported by the chip, but maks-out GPIOs declared as modem control= lines. > > > > - Add patch to refactor GPIO registration. > > > > - Remove patch "serial: sc16is7xx: fix syntax error in comments". > > > > - Remove patch "add dump registers function" > > > > > > > > Hugo Villeneuve (9): > > > > serial: sc16is7xx: mark IOCONTROL register as volatile > > > > serial: sc16is7xx: add post reset delay > > > > serial: sc16is7xx: fix broken port 0 uart init > > > > serial: sc16is7xx: fix bug when first setting GPIO direction > > > > serial: sc16is7xx: refactor GPIO controller registration > > > > dt-bindings: sc16is7xx: Add property to change GPIO function > > > > serial: sc16is7xx: fix regression with GPIO configuration > > > > serial: sc16is7xx: add call to get rs485 DT flags and properties > > > > serial: sc16is7xx: improve comments about variants > > > > > > > > .../bindings/serial/nxp,sc16is7xx.txt | 46 ++++++ > > > > drivers/tty/serial/sc16is7xx.c | 150 +++++++++++++----- > > > > 2 files changed, 156 insertions(+), 40 deletions(-) > > > > > > > > > > > > base-commit: 8b817fded42d8fe3a0eb47b1149d907851a3c942 > > > > > > It would be a lot of sending, to do that for every patch separately, = so for whole series: > > > Reviewed-by: Lech Perczak > > > > > > And where applicable - for code patches: > > > Tested-by: Lech Perczak > > > > > > I tested whole series at the same time. > > > I did my tests on an i.MX6 board with SC16IS760 over SPI, which diffe= rs a tiny bit from SC16IS752, > > > and everything works as it should. > > > Thank you for fixing this! > > > > Hi Lech, > > thank for your feedback. > > > > You mentioned before that without the patch "mark IOCONTROL register as= volatile", things were not working properly for you. Could you retest by r= emoving this patch and see if things are still working? > > > > Thank you, Hugo. >=20 > Hello Hugo, >=20 > Just checked - this patch is required, reverting it causes things to fail= , so this patch should be marked as a pre-requisite for the actual fix and = included in backports. > Perhaps using direct write to this register made it work, but it was like= ly by accident. Hi Lech, thank you for the test, I will mark it as such in upcoming series V5. Hugo.