devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts
@ 2023-05-31 10:21 Oleksij Rempel
  2023-05-31 10:21 ` [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names Oleksij Rempel
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Oleksij Rempel @ 2023-05-31 10:21 UTC (permalink / raw)
  To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
	Krzysztof Kozlowski, Jérôme Pouiller
  Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32,
	linux-arm-kernel, devicetree, netdev

changes v3:
- reword commit message for the pse-controller.yaml patch
- drop podl-pse-regulator.yaml patch

changes v2:
- extend ethernet-pse regexp in the PoDL PSE dt-bindings

This patch set comes in response to issues identified while adding PoDL
PSE support to the stm32 prtt1c device tree. The existing pse-pd device
tree bindings did not allow node name patterns like "ethernet-pse-0" and
"ethernet-pse-1", leading to validation failures.

To address these false positives in validation, the device tree bindings
are extended to support these node name patterns. Alongside this, an
example node is added to aid in the improved validation process.
Following these changes, the updated PoDL PSE regulator nodes are then
added to the stm32 prtt1c device tree.

Oleksij Rempel (2):
  dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names
  ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes

 .../bindings/net/pse-pd/pse-controller.yaml   |  2 +-
 arch/arm/boot/dts/stm32mp151a-prtt1c.dts      | 32 +++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names
  2023-05-31 10:21 [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts Oleksij Rempel
@ 2023-05-31 10:21 ` Oleksij Rempel
  2023-06-01 17:34   ` Krzysztof Kozlowski
  2023-05-31 10:21 ` [PATCH v3 2/2] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes Oleksij Rempel
  2023-06-02  5:00 ` [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts patchwork-bot+netdevbpf
  2 siblings, 1 reply; 5+ messages in thread
From: Oleksij Rempel @ 2023-05-31 10:21 UTC (permalink / raw)
  To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
	Krzysztof Kozlowski, Jérôme Pouiller
  Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32,
	linux-arm-kernel, devicetree, netdev

Extend the pattern matching for PSE-PD controller nodes to allow -N
suffixes. This enables the use of multiple "ethernet-pse" nodes without the
need for a "reg" property.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../devicetree/bindings/net/pse-pd/pse-controller.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml
index b110abb42597..2d382faca0e6 100644
--- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml
+++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml
@@ -16,7 +16,7 @@ maintainers:
 
 properties:
   $nodename:
-    pattern: "^ethernet-pse(@.*)?$"
+    pattern: "^ethernet-pse(@.*|-([0-9]|[1-9][0-9]+))?$"
 
   "#pse-cells":
     description:
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/2] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes
  2023-05-31 10:21 [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts Oleksij Rempel
  2023-05-31 10:21 ` [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names Oleksij Rempel
@ 2023-05-31 10:21 ` Oleksij Rempel
  2023-06-02  5:00 ` [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts patchwork-bot+netdevbpf
  2 siblings, 0 replies; 5+ messages in thread
From: Oleksij Rempel @ 2023-05-31 10:21 UTC (permalink / raw)
  To: Maxime Coquelin, Alexandre Torgue, Rob Herring,
	Krzysztof Kozlowski, Jérôme Pouiller
  Cc: Oleksij Rempel, kernel, linux-kernel, linux-stm32,
	linux-arm-kernel, devicetree, netdev

This commit introduces Power over Data Line (PoDL) Power Source
Equipment (PSE) regulator nodes to the PRTT1C devicetree. The addition
of these nodes enables support for PoDL in PRTT1C devices, allowing
power delivery and data transmission over a single twisted pair.

The new PoDL PSE regulator nodes provide voltage capability information
of the current board design, which can be used as a hint for system
administrators when configuring and managing power settings. This update
enhances the versatility and simplifies the power management of PRTT1C
devices while ensuring compatibility with connected Powered Devices
(PDs).

After applying this patch, the power delivery can be controlled from
user space with a patched [1] ethtool version using the following commands:
  ethtool --set-pse t1l2 podl-pse-admin-control enable
to enable power delivery, and
  ethtool --show-pse t1l2
to display the PoDL PSE settings.

By integrating PoDL PSE support into the PRTT1C devicetree, users can
benefit from streamlined power and data connections in their
deployments, improving overall system efficiency and reducing cabling
complexity.

[1] https://lore.kernel.org/all/20230317093024.1051999-1-o.rempel@pengutronix.de/

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/stm32mp151a-prtt1c.dts | 32 ++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp151a-prtt1c.dts b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
index 58bb05a8c685..ca0d3329cfd7 100644
--- a/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
+++ b/arch/arm/boot/dts/stm32mp151a-prtt1c.dts
@@ -23,6 +23,18 @@ clock_sja1105: clock-sja1105 {
 		clock-frequency = <25000000>;
 	};
 
+	pse_t1l1: ethernet-pse-1 {
+		compatible = "podl-pse-regulator";
+		pse-supply = <&reg_t1l1>;
+		#pse-cells = <0>;
+	};
+
+	pse_t1l2: ethernet-pse-2 {
+		compatible = "podl-pse-regulator";
+		pse-supply = <&reg_t1l2>;
+		#pse-cells = <0>;
+	};
+
 	mdio0: mdio {
 		compatible = "virtual,mdio-gpio";
 		#address-cells = <1>;
@@ -32,6 +44,24 @@ mdio0: mdio {
 
 	};
 
+	reg_t1l1: regulator-pse-t1l1 {
+		compatible = "regulator-fixed";
+		regulator-name = "pse-t1l1";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+		gpio = <&gpiog 13 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	reg_t1l2: regulator-pse-t1l2 {
+		compatible = "regulator-fixed";
+		regulator-name = "pse-t1l2";
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+		gpio = <&gpiog 14 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
 	wifi_pwrseq: wifi-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		reset-gpios = <&gpiod 8 GPIO_ACTIVE_LOW>;
@@ -92,6 +122,7 @@ t1l1_phy: ethernet-phy@7 {
 		reset-gpios = <&gpiog 12 GPIO_ACTIVE_LOW>;
 		reset-assert-us = <10>;
 		reset-deassert-us = <35>;
+		pses = <&pse_t1l1>;
 	};
 
 	/* TI DP83TD510E */
@@ -102,6 +133,7 @@ t1l2_phy: ethernet-phy@10 {
 		reset-gpios = <&gpiog 11 GPIO_ACTIVE_LOW>;
 		reset-assert-us = <10>;
 		reset-deassert-us = <35>;
+		pses = <&pse_t1l2>;
 	};
 
 	/* Micrel KSZ9031 */
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names
  2023-05-31 10:21 ` [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names Oleksij Rempel
@ 2023-06-01 17:34   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-01 17:34 UTC (permalink / raw)
  To: Oleksij Rempel, Maxime Coquelin, Alexandre Torgue, Rob Herring,
	Krzysztof Kozlowski, Jérôme Pouiller
  Cc: kernel, linux-kernel, linux-stm32, linux-arm-kernel, devicetree,
	netdev

On 31/05/2023 12:21, Oleksij Rempel wrote:
> Extend the pattern matching for PSE-PD controller nodes to allow -N
> suffixes. This enables the use of multiple "ethernet-pse" nodes without the
> need for a "reg" property.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts
  2023-05-31 10:21 [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts Oleksij Rempel
  2023-05-31 10:21 ` [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names Oleksij Rempel
  2023-05-31 10:21 ` [PATCH v3 2/2] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes Oleksij Rempel
@ 2023-06-02  5:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-02  5:00 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: mcoquelin.stm32, alexandre.torgue, robh+dt, krzk+dt,
	jerome.pouiller, kernel, linux-kernel, linux-stm32,
	linux-arm-kernel, devicetree, netdev

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 31 May 2023 12:21:11 +0200 you wrote:
> changes v3:
> - reword commit message for the pse-controller.yaml patch
> - drop podl-pse-regulator.yaml patch
> 
> changes v2:
> - extend ethernet-pse regexp in the PoDL PSE dt-bindings
> 
> [...]

Here is the summary with links:
  - [v3,1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names
    https://git.kernel.org/netdev/net-next/c/bd415f6c748e
  - [v3,2/2] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes
    (no matching commit)

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-06-02  5:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31 10:21 [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts Oleksij Rempel
2023-05-31 10:21 ` [PATCH v3 1/2] dt-bindings: net: pse-pd: Allow -N suffix for ethernet-pse node names Oleksij Rempel
2023-06-01 17:34   ` Krzysztof Kozlowski
2023-05-31 10:21 ` [PATCH v3 2/2] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes Oleksij Rempel
2023-06-02  5:00 ` [PATCH v3 0/2] Extend dt-bindings for PSE-PD controllers and update prtt1c dts patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).