devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] dt-bindings: watchdog: cdns,wdt-r1p2: Convert cadence watchdog to yaml
@ 2023-06-01  5:22 Srinivas Neeli
  2023-06-30 17:16 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Neeli @ 2023-06-01  5:22 UTC (permalink / raw)
  To: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	srinivas.neeli
  Cc: linux-watchdog, linux-kernel, devicetree, radhey.shyam.pandey,
	git, neelisrinivas18, srinivas.goud

Convert cadence watchdog bindings to DT schema format using json-schema.

Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in V2:
- Added missing mailing list emails.
  Conor Dooley <conor+dt@kernel.org>
  devicetree@vger.kernel.org
---
 .../bindings/watchdog/cadence-wdt.txt         | 23 -------
 .../bindings/watchdog/cdns,wdt-r1p2.yaml      | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 23 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/cadence-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/cdns,wdt-r1p2.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/cadence-wdt.txt b/Documentation/devicetree/bindings/watchdog/cadence-wdt.txt
deleted file mode 100644
index 750a87657448..000000000000
--- a/Documentation/devicetree/bindings/watchdog/cadence-wdt.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-Zynq Watchdog Device Tree Bindings
--------------------------------------------
-
-Required properties:
-- compatible		: Should be "cdns,wdt-r1p2".
-- clocks		: This is pclk (APB clock).
-- interrupts		: This is wd_irq - watchdog timeout interrupt.
-
-Optional properties
-- reset-on-timeout	: If this property exists, then a reset is done
-			  when watchdog times out.
-- timeout-sec		: Watchdog timeout value (in seconds).
-
-Example:
-	watchdog@f8005000 {
-		compatible = "cdns,wdt-r1p2";
-		clocks = <&clkc 45>;
-		interrupt-parent = <&intc>;
-		interrupts = <0 9 1>;
-		reg = <0xf8005000 0x1000>;
-		reset-on-timeout;
-		timeout-sec = <10>;
-	};
diff --git a/Documentation/devicetree/bindings/watchdog/cdns,wdt-r1p2.yaml b/Documentation/devicetree/bindings/watchdog/cdns,wdt-r1p2.yaml
new file mode 100644
index 000000000000..3c17c5883bce
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/cdns,wdt-r1p2.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/cdns,wdt-r1p2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cadence watchdog timer controller
+
+maintainers:
+  - Neeli Srinivas <srinivas.neeli@amd.com>
+
+description:
+  The cadence watchdog timer is used to detect and recover from
+  system malfunctions. This watchdog contains 24 bit counter and
+  a programmable reset period. The timeout period varies from 1 ms
+  to 30 seconds while using a 100Mhz clock.
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    enum:
+      - cdns,wdt-r1p2
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  reset-on-timeout:
+    type: boolean
+    description: |
+      If this property exists, then a reset is done when watchdog
+      times out.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    watchdog@f8005000 {
+        compatible = "cdns,wdt-r1p2";
+        reg = <0xf8005000 0x1000>;
+        clocks = <&clkc 45>;
+        interrupt-parent = <&intc>;
+        interrupts = <GIC_SPI 9 IRQ_TYPE_EDGE_RISING>;
+        reset-on-timeout;
+        timeout-sec = <10>;
+    };
+...
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] dt-bindings: watchdog: cdns,wdt-r1p2: Convert cadence watchdog to yaml
  2023-06-01  5:22 [PATCH V2] dt-bindings: watchdog: cdns,wdt-r1p2: Convert cadence watchdog to yaml Srinivas Neeli
@ 2023-06-30 17:16 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-06-30 17:16 UTC (permalink / raw)
  To: Srinivas Neeli
  Cc: conor+dt, linux-kernel, srinivas.goud, robh+dt, wim,
	linux-watchdog, devicetree, radhey.shyam.pandey, git,
	krzysztof.kozlowski+dt, linux, neelisrinivas18

On Thu, 01 Jun 2023 10:52:37 +0530, Srinivas Neeli wrote:
> Convert cadence watchdog bindings to DT schema format using json-schema.
> 
> Signed-off-by: Srinivas Neeli <srinivas.neeli@amd.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes in V2:
> - Added missing mailing list emails.
>   Conor Dooley <conor+dt@kernel.org>
>   devicetree@vger.kernel.org
> ---
>  .../bindings/watchdog/cadence-wdt.txt         | 23 -------
>  .../bindings/watchdog/cdns,wdt-r1p2.yaml      | 62 +++++++++++++++++++
>  2 files changed, 62 insertions(+), 23 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/cadence-wdt.txt
>  create mode 100644 Documentation/devicetree/bindings/watchdog/cdns,wdt-r1p2.yaml
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-30 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01  5:22 [PATCH V2] dt-bindings: watchdog: cdns,wdt-r1p2: Convert cadence watchdog to yaml Srinivas Neeli
2023-06-30 17:16 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).