From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0727C7EE23 for ; Thu, 1 Jun 2023 10:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbjFAKqB (ORCPT ); Thu, 1 Jun 2023 06:46:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233101AbjFAKpx (ORCPT ); Thu, 1 Jun 2023 06:45:53 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07485D7; Thu, 1 Jun 2023 03:45:36 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 351AjSNs000472; Thu, 1 Jun 2023 05:45:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685616328; bh=b57GyCHHcN+WR2u7Nl4USXLq5ydgvq86TOP8E4lF7iM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=eJhq7InjL/8VJum/lHidQvIFlr4U9ckJXjL+NJUBUnggsYrFep1+Dlftj6889kp8t G93TrQIxnzkv74bW662riywEo/mvR6W3gVTgzgPNhdHAZHMMGUX30cmikO60Mcorxq eGor+Z73MGtDpsyw9jgpmtaWrLs/3cnK/GXsNmjs= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 351AjSxx080412 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Jun 2023 05:45:28 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 1 Jun 2023 05:45:27 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 05:45:27 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 351AjR5O018592; Thu, 1 Jun 2023 05:45:27 -0500 Date: Thu, 1 Jun 2023 05:45:27 -0500 From: Nishanth Menon To: Udit Kumar CC: , , , , , , , , , Subject: Re: [PATCH v2 3/5] arm64: dts: ti: k3-j7200-common-proc-board: main_pmx0 clean up Message-ID: <20230601104527.luzqw4m2aidsuw4x@booting> References: <20230601093744.1565802-1-u-kumar1@ti.com> <20230601093744.1565802-4-u-kumar1@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230601093744.1565802-4-u-kumar1@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15:07-20230601, Udit Kumar wrote: > Add main_uart0 pin mux in board common file $subject is a bit misleading.. I think the intent is to mux the console explicitly rather than a pinmux cleanup itself. > > Signed-off-by: Udit Kumar > --- > arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > index 0cc0e1dc40c5..02d2e4b36b18 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts > @@ -113,6 +113,15 @@ J721E_IOPAD(0xd8, PIN_INPUT_PULLUP, 0) /* (W2) I2C0_SDA */ > >; > }; > > + main_uart0_pins_default: main_uart0_pins_default { > + pinctrl-single,pins = < > + J721E_IOPAD(0xb0, PIN_INPUT, 0) /* (T16) UART0_RXD */ > + J721E_IOPAD(0xb4, PIN_OUTPUT, 0) /* (T17) UART0_TXD */ > + J721E_IOPAD(0xc0, PIN_INPUT, 2) /* (W3) SPI0_CS0.UART0_CTSn */ > + J721E_IOPAD(0xc4, PIN_OUTPUT, 2) /* (U5) SPI0_CS1.UART0_RTSn */ > + >; > + }; > + > main_i2c1_pins_default: main-i2c1-pins-default { > pinctrl-single,pins = < > J721E_IOPAD(0xdc, PIN_INPUT_PULLUP, 3) /* (U3) ECAP0_IN_APWM_OUT.I2C1_SCL */ > @@ -162,6 +171,8 @@ &main_uart0 { > status = "okay"; > /* Shared with ATF on this platform */ > power-domains = <&k3_pds 146 TI_SCI_PD_SHARED>; > + pinctrl-names = "default"; > + pinctrl-0 = <&main_uart0_pins_default>; > }; > > &main_uart1 { > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D