From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DD3C7EE24 for ; Fri, 2 Jun 2023 07:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233609AbjFBHUs (ORCPT ); Fri, 2 Jun 2023 03:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233227AbjFBHUr (ORCPT ); Fri, 2 Jun 2023 03:20:47 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F131FC0; Fri, 2 Jun 2023 00:20:46 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 658688111; Fri, 2 Jun 2023 07:20:46 +0000 (UTC) Date: Fri, 2 Jun 2023 10:20:45 +0300 From: Tony Lindgren To: Francesco Dolcini Cc: Nishanth Menon , Vignesh Raghavendra , Francesco Dolcini , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v2 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al. Message-ID: <20230602072045.GO14287@atomide.com> References: <20230601131332.26877-1-francesco@dolcini.it> <20230601131332.26877-2-francesco@dolcini.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601131332.26877-2-francesco@dolcini.it> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, * Francesco Dolcini [230601 13:15]: > From: Francesco Dolcini > > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its > nonwifi and wifi variants and the carrier boards (Dahlia, > Verdin Development Board and Yavia) they may be mated in. Looks like you have wifi on sdio, there should be no need for separate compatible properties. The sdio wifi will try to probe and will just bail out if no wifi is populated. If however the non-wifi variants are recycling the sdio pins for something else, then it's it's a different story. In that case you want either seprate compatible properties, or want to use dts fragments possibly. Regards, Tony