From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DDDC7EE29 for ; Sun, 4 Jun 2023 10:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231156AbjFDK1x (ORCPT ); Sun, 4 Jun 2023 06:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231148AbjFDK1w (ORCPT ); Sun, 4 Jun 2023 06:27:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640DFA3; Sun, 4 Jun 2023 03:27:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0026A6119D; Sun, 4 Jun 2023 10:27:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4881C433D2; Sun, 4 Jun 2023 10:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685874470; bh=GDFD2QaDPXXZG69Pe6qfg/v2YwVstAycrro3d0aXXw8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F9gEOFAag92qMFuczSBuQUu/wejjL/Bk2+RZXcZKa0sCYHy9XSjw98lwVQVotNUNu BcHK3HHdEY8FCk1oBS970nOvqLt8z9kJTT/Kr/vbWu0LpMMat8q9pu4zXoDt6hMub5 nOp1c4/QpKKAO04HqI8Csf3oZScLR50Yqj9YlYCXmApdxkfEhQXGLdgP7SU+7xp0i2 Z0oOt4T4e+GyyV888gGFpEB0ZYMkce8QgybjvUcIDIRHu6eN0uaS6w6tRTu7Pq6Qbd EfTf/Z5n5QpCBxESakyOYxqa8nz7B0HSK1XT8N/KE2Yv1yiF/7zc/M7VKSwvQ8TYZs rVpp+FlV0ClQw== Date: Sun, 4 Jun 2023 11:27:45 +0100 From: Jonathan Cameron To: andy.shevchenko@gmail.com Cc: Shreeya Patel , lars@metafoo.de, heiko@sntech.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sebastian.reichel@collabora.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, gustavo.padovan@collabora.com, kernel@collabora.com, serge.broslavsky@collabora.com Subject: Re: [PATCH v3 0/8] RK3588 ADC support Message-ID: <20230604112745.402beb1c@jic23-huawei> In-Reply-To: References: <20230603185340.13838-1-shreeya.patel@collabora.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 3 Jun 2023 23:50:09 +0300 andy.shevchenko@gmail.com wrote: > Sun, Jun 04, 2023 at 12:23:32AM +0530, Shreeya Patel kirjoitti: > > This patch series adds ADC support for RK3588 and updates > > the DT bindings for the same. > > > > To test ADC support on Rock 5B board, a voltage divider circuit > > was created using the gpio pin 22 ( SARADC_IN4 ) and few more > > tests were ran for testing the buffer and trigger support using > > the iio_generic_buffer tool. > > Well done! > > For patches 1-6 > Reviewed-by: Andy Shevchenko > (with one nit-pick to be addressed) Addressed the nit whilst applying and picked up 1-6,8. Applied them to the togreg branch of iio.git, but initially I'll just push that out as testing for 0-day to take a look and see what we missed. As normal 7 should go via appropriate SoC tree > > > Changes in v3 > > - Add bitfield.h header file in patch 2. > > - Add a Reviewed-by tag in patch 2. > > - Do not remove clock enabling and disabling from the suspend and > > resume functions respectively in patch 3 > > > > Changes in v2 > > - Add from address in patches 1 and 2. > > - Create separate patches for adding new device support and changes to > > the old device code. > > - Make use of FIELD_PREP in patch 2. > > - Move the enablement of clocks at it's original position in patch 3 > > - Add Reviewed-by tag in patches 4 and 5. > > - Add an Acked-by tag in patch 8. > > > > Shreeya Patel (8): > > iio: adc: rockchip_saradc: Add callback functions > > iio: adc: rockchip_saradc: Add support for RK3588 > > iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled > > iio: adc: rockchip_saradc: Use of_device_get_match_data > > iio: adc: rockchip_saradc: Match alignment with open parenthesis > > iio: adc: rockchip_saradc: Use dev_err_probe > > arm64: dts: rockchip: Add DT node for ADC support in RK3588 > > dt-bindings: iio: adc: Add rockchip,rk3588-saradc string > > > > .../bindings/iio/adc/rockchip-saradc.yaml | 1 + > > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 12 + > > drivers/iio/adc/rockchip_saradc.c | 246 +++++++++++------- > > 3 files changed, 168 insertions(+), 91 deletions(-) > > > > -- > > 2.30.2 > > >