* [PATCH v2 2/3] ARM: dts: imx: Use 'pmic' as node name
2023-05-27 20:50 [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Fabio Estevam
@ 2023-05-27 20:50 ` Fabio Estevam
2023-05-30 13:01 ` Krzysztof Kozlowski
2023-06-04 12:23 ` Shawn Guo
2023-05-27 20:50 ` [PATCH v2 3/3] ARM: dts: imx6ul-ccimx6ulsom: Fix the "coin" regulator name Fabio Estevam
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Fabio Estevam @ 2023-05-27 20:50 UTC (permalink / raw)
To: shawnguo
Cc: broonie, robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Devicetree node names should be generic. Use 'pmic' as node name
to avoid devicetree check warning from pfuze100.yaml.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Convert more devicetrees that were missed in v1.
arch/arm/boot/dts/imx6dl-riotboard.dts | 2 +-
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
arch/arm/boot/dts/imx6q-gw5400-a.dts | 2 +-
arch/arm/boot/dts/imx6q-novena.dts | 2 +-
arch/arm/boot/dts/imx6q-pistachio.dts | 2 +-
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi | 2 +-
arch/arm/boot/dts/imx6sl-evk.dts | 2 +-
arch/arm/boot/dts/imx6sx-sdb-reva.dts | 2 +-
arch/arm/boot/dts/imx6sx-sdb.dts | 2 +-
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 2 +-
arch/arm/boot/dts/imx6ul-pico.dtsi | 2 +-
arch/arm/boot/dts/imx7d-nitrogen7.dts | 2 +-
arch/arm/boot/dts/imx7d-pico.dtsi | 2 +-
arch/arm/boot/dts/imx7d-sdb.dts | 2 +-
arch/arm/boot/dts/imx7s-warp.dts | 2 +-
18 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 24c7f535f63b..0366d1037ef4 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -177,7 +177,7 @@ codec: sgtl5000@a {
VDDIO-supply = <®_3p3v>;
};
- pmic: pf0100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
interrupt-parent = <&gpio5>;
diff --git a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
index 9591848cbd37..3815cb660ff7 100644
--- a/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
+++ b/arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
@@ -134,7 +134,7 @@ &pinctrl_stmpe2
&pinctrl_pfuze>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
interrupt-parent = <&gpio3>;
diff --git a/arch/arm/boot/dts/imx6q-gw5400-a.dts b/arch/arm/boot/dts/imx6q-gw5400-a.dts
index 522a51042965..0ba802b891b5 100644
--- a/arch/arm/boot/dts/imx6q-gw5400-a.dts
+++ b/arch/arm/boot/dts/imx6q-gw5400-a.dts
@@ -206,7 +206,7 @@ &i2c2 {
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6q-novena.dts b/arch/arm/boot/dts/imx6q-novena.dts
index ee8c0bd3ecfd..a7d5a68110fc 100644
--- a/arch/arm/boot/dts/imx6q-novena.dts
+++ b/arch/arm/boot/dts/imx6q-novena.dts
@@ -308,7 +308,7 @@ &i2c2 {
pinctrl-0 = <&pinctrl_i2c2_novena>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6q-pistachio.dts b/arch/arm/boot/dts/imx6q-pistachio.dts
index bad8d831e64e..109b46a22b5e 100644
--- a/arch/arm/boot/dts/imx6q-pistachio.dts
+++ b/arch/arm/boot/dts/imx6q-pistachio.dts
@@ -208,7 +208,7 @@ &i2c2 {
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
index 4e20cb97058e..e60efb6488a3 100644
--- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
@@ -400,7 +400,7 @@ &i2c2 {
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index f79caa36f3d2..68e97180d33e 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -336,7 +336,7 @@ &i2c2 {
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 53b080c97f2d..4fe58764b929 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -338,7 +338,7 @@ ov5640_to_mipi_csi2: endpoint {
};
};
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi
index bf86b639fdac..9b8c9c23ab54 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard-revd1.dtsi
@@ -27,7 +27,7 @@ &i2c3 {
pinctrl-0 = <&pinctrl_i2c3>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index dc5d596c18db..239bc6dfc584 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -160,7 +160,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6sx-sdb-reva.dts b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
index 7dda42553f4b..48f19dede467 100644
--- a/arch/arm/boot/dts/imx6sx-sdb-reva.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb-reva.dts
@@ -15,7 +15,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze100";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts
index 969cfe920d25..e05a1be5553c 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dts
+++ b/arch/arm/boot/dts/imx6sx-sdb.dts
@@ -14,7 +14,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze200";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
index b9a1401e6c6d..bfcd8f7d86dd 100644
--- a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
+++ b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
@@ -171,7 +171,7 @@ proximity: sx9500@28 {
reset-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>;
};
- pmic: pfuze100@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze200";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx6ul-pico.dtsi b/arch/arm/boot/dts/imx6ul-pico.dtsi
index 357ffb2f5ad6..4ffe99ed55ca 100644
--- a/arch/arm/boot/dts/imx6ul-pico.dtsi
+++ b/arch/arm/boot/dts/imx6ul-pico.dtsi
@@ -131,7 +131,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze3000@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze3000";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx7d-nitrogen7.dts b/arch/arm/boot/dts/imx7d-nitrogen7.dts
index a31de900139d..9c6476bda4a0 100644
--- a/arch/arm/boot/dts/imx7d-nitrogen7.dts
+++ b/arch/arm/boot/dts/imx7d-nitrogen7.dts
@@ -159,7 +159,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze3000@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze3000";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi
index e0bff39e8d3e..73d90845e85c 100644
--- a/arch/arm/boot/dts/imx7d-pico.dtsi
+++ b/arch/arm/boot/dts/imx7d-pico.dtsi
@@ -170,7 +170,7 @@ &i2c4 {
pinctrl-0 = <&pinctrl_i2c4>;
status = "okay";
- pmic: pfuze3000@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze3000";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index c9f6137e73e7..cc9b8570ed4d 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -275,7 +275,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze3000@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze3000";
reg = <0x08>;
diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
index e8734d218b9d..ba7231b364bb 100644
--- a/arch/arm/boot/dts/imx7s-warp.dts
+++ b/arch/arm/boot/dts/imx7s-warp.dts
@@ -94,7 +94,7 @@ &i2c1 {
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- pmic: pfuze3000@8 {
+ pmic: pmic@8 {
compatible = "fsl,pfuze3000";
reg = <0x08>;
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2 3/3] ARM: dts: imx6ul-ccimx6ulsom: Fix the "coin" regulator name
2023-05-27 20:50 [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Fabio Estevam
2023-05-27 20:50 ` [PATCH v2 2/3] ARM: dts: imx: Use 'pmic' as node name Fabio Estevam
@ 2023-05-27 20:50 ` Fabio Estevam
2023-06-04 12:24 ` Shawn Guo
2023-05-30 12:57 ` [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Krzysztof Kozlowski
2023-05-30 15:30 ` (subset) " Mark Brown
3 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2023-05-27 20:50 UTC (permalink / raw)
To: shawnguo
Cc: broonie, robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
As documented in pfuze100.yaml, the correct name for the regulator is
"coin", so change it to fix the following DT check warning:
imx6ul-ccimx6ulsbcexpress.dtb: pmic@8: regulators: 'vcoin' does not match any of the regexes:
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Keep the node and change the name from vcoin to coin.
arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi
index b5781c3656d1..7d1a391431bd 100644
--- a/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi
+++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsom.dtsi
@@ -158,7 +158,7 @@ ldo4_ext: vldo4 {
regulator-max-microvolt = <3300000>;
};
- vcoin_chg: vcoin {
+ vcoin_chg: coin {
regulator-min-microvolt = <2500000>;
regulator-max-microvolt = <3300000>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts
2023-05-27 20:50 [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Fabio Estevam
2023-05-27 20:50 ` [PATCH v2 2/3] ARM: dts: imx: Use 'pmic' as node name Fabio Estevam
2023-05-27 20:50 ` [PATCH v2 3/3] ARM: dts: imx6ul-ccimx6ulsom: Fix the "coin" regulator name Fabio Estevam
@ 2023-05-30 12:57 ` Krzysztof Kozlowski
2023-05-30 12:59 ` Krzysztof Kozlowski
2023-05-30 15:30 ` (subset) " Mark Brown
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 12:57 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, linux-arm-kernel, devicetree, Conor Dooley,
conor+dt, krzysztof.kozlowski+dt, robh+dt, broonie, shawnguo
On Sat, 27 May 2023 17:50:46 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The PFUZE100 PMIC has an interrupt pin that can be connected to
> the host SoC. Describe it in the dt-bindings to avoid warnings like:
>
> imx6q-zii-rdu2.dtb: pmic@8: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/regulator/pfuze100.yaml
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Changes since v1:
> - None. Only collected Conor's Reviewed-by tag.
>
> Documentation/devicetree/bindings/regulator/pfuze100.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1786770
pf0100@8: $nodename:0: 'pf0100@8' does not match '^pmic@[0-9]$'
arch/arm/boot/dts/imx6dl-riotboard.dtb
pfuze100@8: $nodename:0: 'pfuze100@8' does not match '^pmic@[0-9]$'
arch/arm/boot/dts/imx6dl-gw54xx.dtb
arch/arm/boot/dts/imx6dl-sabreauto.dtb
arch/arm/boot/dts/imx6dl-sabresd.dtb
arch/arm/boot/dts/imx6dl-wandboard-revd1.dtb
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dtb
arch/arm/boot/dts/imx6q-gw5400-a.dtb
arch/arm/boot/dts/imx6q-gw54xx.dtb
arch/arm/boot/dts/imx6q-novena.dtb
arch/arm/boot/dts/imx6q-pistachio.dtb
arch/arm/boot/dts/imx6qp-sabreauto.dtb
arch/arm/boot/dts/imx6qp-sabresd.dtb
arch/arm/boot/dts/imx6qp-wandboard-revd1.dtb
arch/arm/boot/dts/imx6q-sabreauto.dtb
arch/arm/boot/dts/imx6q-sabresd.dtb
arch/arm/boot/dts/imx6q-wandboard-revd1.dtb
arch/arm/boot/dts/imx6sl-evk.dtb
arch/arm/boot/dts/imx6sx-sdb.dtb
arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
arch/arm/boot/dts/imx6sx-sdb-reva.dtb
arch/arm/boot/dts/imx6sx-sdb-sai.dtb
arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
pfuze3000@8: $nodename:0: 'pfuze3000@8' does not match '^pmic@[0-9]$'
arch/arm/boot/dts/imx6ul-pico-dwarf.dtb
arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
arch/arm/boot/dts/imx6ul-pico-pi.dtb
arch/arm/boot/dts/imx7d-nitrogen7.dtb
arch/arm/boot/dts/imx7d-pico-dwarf.dtb
arch/arm/boot/dts/imx7d-pico-hobbit.dtb
arch/arm/boot/dts/imx7d-pico-nymph.dtb
arch/arm/boot/dts/imx7d-pico-pi.dtb
arch/arm/boot/dts/imx7d-sdb.dtb
arch/arm/boot/dts/imx7d-sdb-reva.dtb
arch/arm/boot/dts/imx7d-sdb-sht11.dtb
arch/arm/boot/dts/imx7s-warp.dtb
pmic@8: regulators: 'vcoin' does not match any of the regexes: '^(vsnvs|vref|vrefddr|swbst|coin|v33|vccsd)$', '^sw([1-4]|[1-4][a-c]|[1-4][a-c][a-c])$', '^vgen[1-6]$', '^vldo[1-4]$', 'pinctrl-[0-9]+'
arch/arm/boot/dts/imx6ul-ccimx6ulsbcexpress.dtb
arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dtb
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts
2023-05-27 20:50 [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Fabio Estevam
` (2 preceding siblings ...)
2023-05-30 12:57 ` [PATCH v2 1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts Krzysztof Kozlowski
@ 2023-05-30 15:30 ` Mark Brown
3 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2023-05-30 15:30 UTC (permalink / raw)
To: shawnguo, Fabio Estevam
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, Fabio Estevam, Conor Dooley
On Sat, 27 May 2023 17:50:46 -0300, Fabio Estevam wrote:
> The PFUZE100 PMIC has an interrupt pin that can be connected to
> the host SoC. Describe it in the dt-bindings to avoid warnings like:
>
> imx6q-zii-rdu2.dtb: pmic@8: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/regulator/pfuze100.yaml
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/3] dt-bindings: pfuze100.yaml: Add an entry for interrupts
commit: 87fe0214d7aae5e1152953710489c5ab5469b388
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 10+ messages in thread