* [PATCH v1 01/15] ARM: dts: imx6qdl: vicut1: The sgtl5000 uses i2s not ac97
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 02/15] ARM: dts: imx6dl: prtvt7: Adjust default backlight brightness to 65 Oleksij Rempel
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Robin van der Gracht, Oleksij Rempel, kernel, linux-kernel,
devicetree, linux-arm-kernel, NXP Linux Team, Fabio Estevam
From: Robin van der Gracht <robin@protonic.nl>
According to Documentation/devicetree/bindings/sound/fsl,ssi.txt
'fsl,mode' should be specified for AC97 mode only.
The 'fsl,ssi' documentation doesn't say anything about specifying
'sound-dai-cells' so we'll remove that as well.
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
index c4e6cf0527ba..74017ae5a67a 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
@@ -393,8 +393,6 @@ &pwm3 {
};
&ssi1 {
- #sound-dai-cells = <0>;
- fsl,mode = "ac97-slave";
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 02/15] ARM: dts: imx6dl: prtvt7: Adjust default backlight brightness to 65
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 01/15] ARM: dts: imx6qdl: vicut1: The sgtl5000 uses i2s not ac97 Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 03/15] ARM: dts: imx6dl: prtvt7: Remove touchscreen inversion Oleksij Rempel
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Robin van der Gracht, Oleksij Rempel, kernel, linux-kernel,
devicetree, linux-arm-kernel, NXP Linux Team, Fabio Estevam
From: Robin van der Gracht <robin@protonic.nl>
This commit changes the default brightness level of the backlight on the
prtvt7 device from 20 to 65, roughly equivalent to 75% of the maximum
brightness level defined in the "brightness-levels" property.
The adjustment provides a more optimal default brightness for the
device, improving the overall user experience.
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-prtvt7.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
index a1eb53851794..5e68802fee6d 100644
--- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
+++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
@@ -24,7 +24,7 @@ backlight_lcd: backlight-lcd {
compatible = "pwm-backlight";
pwms = <&pwm1 0 500000 0>;
brightness-levels = <0 20 81 248 1000>;
- default-brightness-level = <20>;
+ default-brightness-level = <65>;
num-interpolated-steps = <21>;
power-supply = <®_bl_12v0>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 03/15] ARM: dts: imx6dl: prtvt7: Remove touchscreen inversion
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 01/15] ARM: dts: imx6qdl: vicut1: The sgtl5000 uses i2s not ac97 Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 02/15] ARM: dts: imx6dl: prtvt7: Adjust default backlight brightness to 65 Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 04/15] ARM: dts: imx6q: prtwd2: Correct iomux configuration for ENET MDIO and MDC Oleksij Rempel
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: David Jander, Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
From: David Jander <david@protonic.nl>
This touchscreen does not seem to be inverted in any axis, so remove these
DT properties.
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-prtvt7.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
index 5e68802fee6d..45bc6e3245f6 100644
--- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
+++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
@@ -267,8 +267,6 @@ touchscreen {
<&adc_ts 5>;
io-channel-names = "y", "z1", "z2", "x";
touchscreen-min-pressure = <64687>;
- touchscreen-inverted-x;
- touchscreen-inverted-y;
touchscreen-x-plate-ohms = <300>;
touchscreen-y-plate-ohms = <800>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 04/15] ARM: dts: imx6q: prtwd2: Correct iomux configuration for ENET MDIO and MDC
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (2 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 03/15] ARM: dts: imx6dl: prtvt7: Remove touchscreen inversion Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 05/15] ARM: dts: imx6dl: lanmcu: Disable unused USB PHY nodes Oleksij Rempel
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Robin van der Gracht, Oleksij Rempel, kernel, linux-kernel,
devicetree, linux-arm-kernel, NXP Linux Team, Fabio Estevam
From: Robin van der Gracht <robin@protonic.nl>
This commit addresses a misconfiguration in the prtwd2 device tree
source. Specifically, the ENET MDIO and MDC pins were mistakenly
assigned to the Ethernet block, while they are actually used by the I2C4
interface.
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6q-prtwd2.dts | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-prtwd2.dts b/arch/arm/boot/dts/imx6q-prtwd2.dts
index 54a57a4548e2..792b8903d345 100644
--- a/arch/arm/boot/dts/imx6q-prtwd2.dts
+++ b/arch/arm/boot/dts/imx6q-prtwd2.dts
@@ -156,9 +156,6 @@ MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1b0b0
MX6QDL_PAD_CSI0_DAT4__GPIO5_IO22 0x1b0b0
/* nINTRP */
MX6QDL_PAD_CSI0_DAT5__GPIO5_IO23 0x1b0b0
-
- MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x10030
- MX6QDL_PAD_ENET_MDC__ENET_MDC 0x10030
>;
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 05/15] ARM: dts: imx6dl: lanmcu: Disable unused USB PHY nodes
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (3 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 04/15] ARM: dts: imx6q: prtwd2: Correct iomux configuration for ENET MDIO and MDC Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 06/15] ARM: dts: imx6dl: lanmcu: Configure over-current polarity for USB OTG node Oleksij Rempel
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
In the imx6dl-lanmcu system, the usbh2 and usbh3 interfaces are not in
use. However, the related USB PHY nodes (usbphynop1 and usbphynop2) are
enabled by default in the imx6qdl.dtsi file, which can lead to confusion
and potential resource mismanagement.
This commit explicitly disables these unused USB PHY nodes in the
imx6dl-lanmcu device tree, aligning the configuration more accurately
with the actual hardware setup.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-lanmcu.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-lanmcu.dts b/arch/arm/boot/dts/imx6dl-lanmcu.dts
index fa823988312d..bbfa921e657d 100644
--- a/arch/arm/boot/dts/imx6dl-lanmcu.dts
+++ b/arch/arm/boot/dts/imx6dl-lanmcu.dts
@@ -260,6 +260,14 @@ &usbotg {
status = "okay";
};
+&usbphynop1 {
+ status = "disabled";
+};
+
+&usbphynop2 {
+ status = "disabled";
+};
+
&usdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc1>;
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 06/15] ARM: dts: imx6dl: lanmcu: Configure over-current polarity for USB OTG node
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (4 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 05/15] ARM: dts: imx6dl: lanmcu: Disable unused USB PHY nodes Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 07/15] ARM: dts: imx6dl: Add trip points to thermal zones on several devices Oleksij Rempel
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
This commit adds the 'over-current-active-low' flag to the USB OTG node
in the imx6dl-lanmcu device tree. This flag is necessary because the
hardware signals over-current conditions by pulling the line low.
Without this flag, the kernel could misinterpret an over-current
condition, leading to unexpected behavior.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-lanmcu.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6dl-lanmcu.dts b/arch/arm/boot/dts/imx6dl-lanmcu.dts
index bbfa921e657d..7c62db91173b 100644
--- a/arch/arm/boot/dts/imx6dl-lanmcu.dts
+++ b/arch/arm/boot/dts/imx6dl-lanmcu.dts
@@ -257,6 +257,7 @@ &usbotg {
pinctrl-0 = <&pinctrl_usbotg>;
phy_type = "utmi";
dr_mode = "host";
+ over-current-active-low;
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 07/15] ARM: dts: imx6dl: Add trip points to thermal zones on several devices
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (5 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 06/15] ARM: dts: imx6dl: lanmcu: Configure over-current polarity for USB OTG node Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 08/15] ARM: dts: imx6dl: vicut1: Address USB related warnings Oleksij Rempel
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
Kernel v6.3-rc1 prints errors due to missing trip points in thermal
zones. These errors indicate a lack of critical temperature threshold
settings, causing warnings at boot. To silence these errors, this patch
introduces trip points into the thermal zones of several imx6dl based
devices.
The following devices are updated:
- plym2m
- prtvt7
- victgo
- vicut1
These devices are automotive grade and expected to operate up to 105C.
An exception is the plym2m, an industrial grade device, which is
certified to work up to 85C.
The added trip points act as alert thresholds but do not trigger any
actions except warnings. This behavior is by design, as these devices
should maintain their performance until the end, without any thermal
throttling.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-plym2m.dts | 24 ++++++++++++++++++++++++
arch/arm/boot/dts/imx6dl-prtvt7.dts | 24 ++++++++++++++++++++++++
arch/arm/boot/dts/imx6dl-victgo.dts | 24 ++++++++++++++++++++++++
arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 8 ++++++++
4 files changed, 80 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts
index e3c10483f33b..dfa8110b1d97 100644
--- a/arch/arm/boot/dts/imx6dl-plym2m.dts
+++ b/arch/arm/boot/dts/imx6dl-plym2m.dts
@@ -113,18 +113,42 @@ chassis-thermal {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&tsens0>;
+
+ trips {
+ alert {
+ temperature = <85000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
touch-thermal0 {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&touch_temp0>;
+
+ trips {
+ alert {
+ temperature = <85000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
touch-thermal1 {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&touch_temp1>;
+
+ trips {
+ alert {
+ temperature = <85000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
};
diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
index 45bc6e3245f6..568e98cb62aa 100644
--- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
+++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
@@ -246,18 +246,42 @@ chassis-thermal {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&tsens0>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
touch-thermal0 {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&touch_temp0>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
touch-thermal1 {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&touch_temp1>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
};
diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
index 23274be08e61..4875afadb630 100644
--- a/arch/arm/boot/dts/imx6dl-victgo.dts
+++ b/arch/arm/boot/dts/imx6dl-victgo.dts
@@ -74,18 +74,42 @@ chassis-thermal {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&tsens0>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
touch-thermal0 {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&touch_temp0>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
touch-thermal1 {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&touch_temp1>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
index 74017ae5a67a..ca9c20e90bcf 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
@@ -169,6 +169,14 @@ chassis-thermal {
polling-delay = <20000>;
polling-delay-passive = <0>;
thermal-sensors = <&tsens0>;
+
+ trips {
+ alert {
+ temperature = <105000>; /* millicelsius */
+ hysteresis = <2000>; /* millicelsius */
+ type = "passive";
+ };
+ };
};
};
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 08/15] ARM: dts: imx6dl: vicut1: Address USB related warnings
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (6 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 07/15] ARM: dts: imx6dl: Add trip points to thermal zones on several devices Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 09/15] ARM: dts: imx6dl: alti6p: fix different " Oleksij Rempel
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
This patch addresses several USB-related warnings in the device tree for
the imx6dl vicut1 system. Specifically, it disables the unused
usbphynop1 and usbphynop2 USB PHYs, and disables unsupported
over-current detection. This action mitigates the following kernel
warnings:
usb_phy_generic usbphynop1: dummy supplies not allowed for exclusive requests
usb_phy_generic usbphynop2: dummy supplies not allowed for exclusive requests
imx_usb 2184200.usb: No over-current polarity defined
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
index ca9c20e90bcf..96e4f4b0b248 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
@@ -432,6 +432,7 @@ &usbh1 {
pinctrl-names = "default";
phy_type = "utmi";
dr_mode = "host";
+ disable-over-current;
status = "okay";
};
@@ -445,6 +446,14 @@ &usbotg {
status = "okay";
};
+&usbphynop1 {
+ status = "disabled";
+};
+
+&usbphynop2 {
+ status = "disabled";
+};
+
&usdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc1>;
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 09/15] ARM: dts: imx6dl: alti6p: fix different USB related warnings
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (7 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 08/15] ARM: dts: imx6dl: vicut1: Address USB related warnings Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 10/15] ARM: dts: imx6dl: prtmvt: " Oleksij Rempel
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
Fix USB-related warnings in imx6dl alti6p device tree by disabling
unused usbphynop1 and usbphynop2 USB PHYs and properly configuring
over-current detection on related ports. This fixes the following
warnings with the current kernel:
usb_phy_generic usbphynop1: dummy supplies not allowed for exclusive requests
usb_phy_generic usbphynop2: dummy supplies not allowed for exclusive requests
imx_usb 2184200.usb: No over-current polarity defined
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-alti6p.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-alti6p.dts b/arch/arm/boot/dts/imx6dl-alti6p.dts
index e6a4e2770640..4989e8d069a1 100644
--- a/arch/arm/boot/dts/imx6dl-alti6p.dts
+++ b/arch/arm/boot/dts/imx6dl-alti6p.dts
@@ -361,6 +361,7 @@ &usbh1 {
pinctrl-0 = <&pinctrl_usbh1>;
phy_type = "utmi";
dr_mode = "host";
+ over-current-active-low;
status = "okay";
};
@@ -370,9 +371,18 @@ &usbotg {
pinctrl-0 = <&pinctrl_usbotg>;
phy_type = "utmi";
dr_mode = "host";
+ over-current-active-low;
status = "okay";
};
+&usbphynop1 {
+ status = "disabled";
+};
+
+&usbphynop2 {
+ status = "disabled";
+};
+
&usdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc1>;
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 10/15] ARM: dts: imx6dl: prtmvt: fix different USB related warnings
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (8 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 09/15] ARM: dts: imx6dl: alti6p: fix different " Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 11/15] ARM: dts: imx6qp: prtwd3: Enable USB over current detection on USB OTG port Oleksij Rempel
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
Fix USB-related warnings in imx6dl prtmvt device tree by disabling
unused usbphynop1 and usbphynop2 USB PHYs and over-current detection
which is not supported on USB h1 port. This fixes the following warnings
with the current kernel:
usb_phy_generic usbphynop1: dummy supplies not allowed for exclusive requests
usb_phy_generic usbphynop2: dummy supplies not allowed for exclusive requests
imx_usb 2184200.usb: No over current polarity defined
By the way, fix over-current detection on usbotg port.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-prtmvt.dts | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-prtmvt.dts b/arch/arm/boot/dts/imx6dl-prtmvt.dts
index 5f4fa796ca18..773a84a5739d 100644
--- a/arch/arm/boot/dts/imx6dl-prtmvt.dts
+++ b/arch/arm/boot/dts/imx6dl-prtmvt.dts
@@ -560,6 +560,7 @@ &usbh1 {
pinctrl-names = "default";
phy_type = "utmi";
dr_mode = "host";
+ disable-over-current;
status = "okay";
};
@@ -569,10 +570,18 @@ &usbotg {
pinctrl-0 = <&pinctrl_usbotg>;
phy_type = "utmi";
dr_mode = "host";
- disable-over-current;
+ over-current-active-low;
status = "okay";
};
+&usbphynop1 {
+ status = "disabled";
+};
+
+&usbphynop2 {
+ status = "disabled";
+};
+
&usdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc1>;
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 11/15] ARM: dts: imx6qp: prtwd3: Enable USB over current detection on USB OTG port
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (9 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 10/15] ARM: dts: imx6dl: prtmvt: " Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 12/15] ARM: dts: imx6ul: prti6g: fix USB over-current " Oleksij Rempel
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
The imx6qp-prtwd3 board supports USB over current detection on the USB
OTG port, however, it was previously disabled in the device tree. This
commit enables the over current detection by changing the device tree
setting from 'disable-over-current' to 'over-current-active-low'. This
could potentially protect the USB port from damage due to over current
situations.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6qp-prtwd3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qp-prtwd3.dts b/arch/arm/boot/dts/imx6qp-prtwd3.dts
index a8154c901d4f..657d112ac3a1 100644
--- a/arch/arm/boot/dts/imx6qp-prtwd3.dts
+++ b/arch/arm/boot/dts/imx6qp-prtwd3.dts
@@ -518,7 +518,7 @@ &usbotg {
pinctrl-0 = <&pinctrl_usbotg>;
phy_type = "utmi";
dr_mode = "host";
- disable-over-current;
+ over-current-active-low;
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 12/15] ARM: dts: imx6ul: prti6g: fix USB over-current detection on USB OTG port
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (10 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 11/15] ARM: dts: imx6qp: prtwd3: Enable USB over current detection on USB OTG port Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 13/15] ARM: dts: imx6dl: plybas: " Oleksij Rempel
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
USB over-current detection is supported on this board. So, activate it
and fixes the following kernel warnings:
imx_usb 2184200.usb: No over current polarity defined
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6ul-prti6g.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6ul-prti6g.dts b/arch/arm/boot/dts/imx6ul-prti6g.dts
index b7c96fbe7a91..c3c50f51a5a8 100644
--- a/arch/arm/boot/dts/imx6ul-prti6g.dts
+++ b/arch/arm/boot/dts/imx6ul-prti6g.dts
@@ -177,6 +177,7 @@ &uart1 {
&usbotg1 {
dr_mode = "host";
+ over-current-active-low;
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 13/15] ARM: dts: imx6dl: plybas: fix USB over-current detection on USB OTG port
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (11 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 12/15] ARM: dts: imx6ul: prti6g: fix USB over-current " Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 14/15] ARM: dts: imx6dl: prtrvt, prtvt7, prti6q, prtwd2: fix USB related warnings Oleksij Rempel
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
USB over-current detection is supported on this board. So, activate it.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-plybas.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
index e98046eea7a4..84f34da06267 100644
--- a/arch/arm/boot/dts/imx6dl-plybas.dts
+++ b/arch/arm/boot/dts/imx6dl-plybas.dts
@@ -235,7 +235,7 @@ &usbotg {
pinctrl-0 = <&pinctrl_usbotg>;
phy_type = "utmi";
dr_mode = "host";
- disable-over-current;
+ over-current-active-low;
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 14/15] ARM: dts: imx6dl: prtrvt, prtvt7, prti6q, prtwd2: fix USB related warnings
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (12 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 13/15] ARM: dts: imx6dl: plybas: " Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-05-30 12:03 ` [PATCH v1 15/15] ARM: dts: imx6qdl: vicut1: rename power to power-button Oleksij Rempel
2023-06-04 13:08 ` [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Shawn Guo
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
Fix USB-related warnings in prtrvt, prtvt7, prti6q and prtwd2 device trees
by disabling unused usbphynop1 and usbphynop2 USB PHYs and providing proper
configuration for the over-current detection. This fixes the following
warnings with the current kernel:
usb_phy_generic usbphynop1: dummy supplies not allowed for exclusive requests
usb_phy_generic usbphynop2: dummy supplies not allowed for exclusive requests
imx_usb 2184200.usb: No over current polarity defined
By the way, fix over-current detection on usbotg port for prtvt7, prti6q
and prtwd2 boards. Only prtrvt do not have OC on USB OTG port.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-prtrvt.dts | 4 ++++
arch/arm/boot/dts/imx6qdl-prti6q.dtsi | 11 ++++++++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-prtrvt.dts b/arch/arm/boot/dts/imx6dl-prtrvt.dts
index 56bb1ca56a2d..36b031236e47 100644
--- a/arch/arm/boot/dts/imx6dl-prtrvt.dts
+++ b/arch/arm/boot/dts/imx6dl-prtrvt.dts
@@ -124,6 +124,10 @@ &usbh1 {
status = "disabled";
};
+&usbotg {
+ disable-over-current;
+};
+
&vpu {
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6qdl-prti6q.dtsi b/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
index f0db0d4471f4..36f84f4da6b0 100644
--- a/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
@@ -69,6 +69,7 @@ &usbh1 {
vbus-supply = <®_usb_h1_vbus>;
phy_type = "utmi";
dr_mode = "host";
+ disable-over-current;
status = "okay";
};
@@ -78,10 +79,18 @@ &usbotg {
pinctrl-0 = <&pinctrl_usbotg>;
phy_type = "utmi";
dr_mode = "host";
- disable-over-current;
+ over-current-active-low;
status = "okay";
};
+&usbphynop1 {
+ status = "disabled";
+};
+
+&usbphynop2 {
+ status = "disabled";
+};
+
&usdhc1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc1>;
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v1 15/15] ARM: dts: imx6qdl: vicut1: rename power to power-button
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (13 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 14/15] ARM: dts: imx6dl: prtrvt, prtvt7, prti6q, prtwd2: fix USB related warnings Oleksij Rempel
@ 2023-05-30 12:03 ` Oleksij Rempel
2023-06-04 13:08 ` [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Shawn Guo
15 siblings, 0 replies; 17+ messages in thread
From: Oleksij Rempel @ 2023-05-30 12:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski
Cc: Oleksij Rempel, kernel, linux-kernel, devicetree,
linux-arm-kernel, NXP Linux Team, Fabio Estevam
In order to address the warnings about the naming convention for keys,
this commit renames the 'power' key to 'power-button' in the vicut1-12inch
device tree source file. The warning in question is as follows:
arch/arm/boot/dts/imx6q-vicut1.dtb: gpio-keys: 'power' does not match
any of the regexes:
'^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$',
'pinctrl-[0-9]+'
The referenced warning originates from the following schema:
Documentation/devicetree/bindings/input/gpio-keys.yaml
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6qdl-vicut1-12inch.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-vicut1-12inch.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1-12inch.dtsi
index f505f2704530..73f381e14467 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1-12inch.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1-12inch.dtsi
@@ -10,7 +10,7 @@ gpio-keys {
pinctrl-0 = <&pinctrl_gpiokeys>;
autorepeat;
- power {
+ power-button {
label = "Power Button";
gpios = <&gpio2 23 GPIO_ACTIVE_LOW>;
linux,code = <KEY_POWER>;
--
2.39.2
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v1 00/15] Maintenance updates for Protonic Holland boards
2023-05-30 12:03 [PATCH v1 00/15] Maintenance updates for Protonic Holland boards Oleksij Rempel
` (14 preceding siblings ...)
2023-05-30 12:03 ` [PATCH v1 15/15] ARM: dts: imx6qdl: vicut1: rename power to power-button Oleksij Rempel
@ 2023-06-04 13:08 ` Shawn Guo
15 siblings, 0 replies; 17+ messages in thread
From: Shawn Guo @ 2023-06-04 13:08 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, kernel,
linux-kernel, devicetree, linux-arm-kernel, NXP Linux Team,
Fabio Estevam
On Tue, May 30, 2023 at 02:03:30PM +0200, Oleksij Rempel wrote:
> This patchset consists of several updates that address issues on
> Protonic Holland's supported i.MX6-based devices, with a particular
> focus on the USB subsystem configuration, thermal zones, and the naming
> of GPIO keys. Some of these changes include the activation of USB over-
> current detection on certain ports, the disabling of unused USB PHY
> nodes, fixing USB-related warnings, adding trip points to thermal zones
> on several devices, and renaming the 'power' key to meet the necessary
> conventions.
>
> David Jander (1):
> ARM: dts: imx6dl: prtvt7: Remove touchscreen inversion
>
> Oleksij Rempel (11):
> ARM: dts: imx6dl: lanmcu: Disable unused USB PHY nodes
> ARM: dts: imx6dl: lanmcu: Configure over-current polarity for USB OTG
> node
> ARM: dts: imx6dl: Add trip points to thermal zones on several devices
> ARM: dts: imx6dl: vicut1: Address USB related warnings
> ARM: dts: imx6dl: alti6p: fix different USB related warnings
> ARM: dts: imx6dl: prtmvt: fix different USB related warnings
> ARM: dts: imx6qp: prtwd3: Enable USB over current detection on USB OTG
> port
> ARM: dts: imx6ul: prti6g: fix USB over-current detection on USB OTG
> port
> ARM: dts: imx6dl: plybas: fix USB over-current detection on USB OTG
> port
> ARM: dts: imx6dl: prtrvt, prtvt7, prti6q, prtwd2: fix USB related
> warnings
> ARM: dts: imx6qdl: vicut1: rename power to power-button
>
> Robin van der Gracht (3):
> ARM: dts: imx6qdl: vicut1: The sgtl5000 uses i2s not ac97
> ARM: dts: imx6dl: prtvt7: Adjust default backlight brightness to 65
> ARM: dts: imx6q: prtwd2: Correct iomux configuration for ENET MDIO and
> MDC
Applied all, thanks!
^ permalink raw reply [flat|nested] 17+ messages in thread