public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-imx@nxp.com, jun.li@nxp.com,
	devicetree@vger.kernel.org, peng.fan@nxp.com
Subject: Re: [PATCH 2/2] usb: chipidea: imx: don't request QoS for imx8ulp
Date: Mon, 5 Jun 2023 07:18:30 +0800	[thread overview]
Message-ID: <20230604231830.GE258497@nchen-desktop> (raw)
In-Reply-To: <20230530104007.1294702-2-xu.yang_2@nxp.com>

On 23-05-30 18:40:07, Xu Yang wrote:
> Use dedicated imx8ulp usb compatible to remove QoS request
> since imx8ulp has no such limitation of imx7ulp: DMA will
> not work if system enters idle.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 9f0f4ec701c5..336ef6dd8e7d 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -70,6 +70,10 @@ static const struct ci_hdrc_imx_platform_flag imx7ulp_usb_data = {
>  		CI_HDRC_PMQOS,
>  };
>  
> +static const struct ci_hdrc_imx_platform_flag imx8ulp_usb_data = {
> +	.flags = CI_HDRC_SUPPORTS_RUNTIME_PM,
> +};
> +
>  static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
>  	{ .compatible = "fsl,imx23-usb", .data = &imx23_usb_data},
>  	{ .compatible = "fsl,imx28-usb", .data = &imx28_usb_data},
> @@ -80,6 +84,7 @@ static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
>  	{ .compatible = "fsl,imx6ul-usb", .data = &imx6ul_usb_data},
>  	{ .compatible = "fsl,imx7d-usb", .data = &imx7d_usb_data},
>  	{ .compatible = "fsl,imx7ulp-usb", .data = &imx7ulp_usb_data},
> +	{ .compatible = "fsl,imx8ulp-usb", .data = &imx8ulp_usb_data},
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, ci_hdrc_imx_dt_ids);
> -- 
> 2.34.1
> 

Acked-by: Peter Chen <peter.chen@kernel.org>

-- 

Thanks,
Peter Chen

  reply	other threads:[~2023-06-04 23:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 10:40 [PATCH 1/2] dt-bindings: usb: ci-hdrc-usb2: add fsl,imx8ulp-usb compatible Xu Yang
2023-05-30 10:40 ` [PATCH 2/2] usb: chipidea: imx: don't request QoS for imx8ulp Xu Yang
2023-06-04 23:18   ` Peter Chen [this message]
2023-05-31 17:23 ` [PATCH 1/2] dt-bindings: usb: ci-hdrc-usb2: add fsl,imx8ulp-usb compatible Krzysztof Kozlowski
2023-06-01  2:54   ` [EXT] " Xu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230604231830.GE258497@nchen-desktop \
    --to=peter.chen@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox