Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2816 bytes --]

On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote:
> Hello Conor,
> 
> pet, 19. svi 2023. u 18:41 Conor Dooley <conor@kernel.org> napisao je:
> >
> > Hey Paulo,
> >
> > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote:
> > >
> > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
> > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires
> > > DCS initialization sequences with certain delays between certain
> > > commands.
> > >
> > > Signed-off-by: Paulo Pavacic <pavacic.p@gmail.com>
> > > ---
> > > v3 changelog:
> > >   - renamed yml file
> > >   - refactored yml file to describe fannal,c3004
> > >   - added matrix URI to MAINTAINERS
> > > v2 changelog:
> > >   - revised driver title, now describes purpose
> > >   - revised description, now describes hw
> > >   - revised maintainers, now has only 1 mail
> > >   - removed diacritics from commit/commit author
> > >   - properties/compatible is now enum
> > >   - compatible using only lowercase
> > >   - revised dts example
> > >   - modified MAINTAINERS in this commit (instead of driver commit)
> > >   - dt_bindings_check checked yml
> > >   - checkpatch warning fixed
> > > ---
> > >  .../bindings/display/panel/fannal,c3004.yaml  | 75 +++++++++++++++++++
> > >  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> > >  MAINTAINERS                                   |  6 ++
> > >  3 files changed, 83 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > new file mode 100644
> > > index 000000000000..a86b5ce02aa2
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > @@ -0,0 +1,75 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Fannal C3004 MIPI-DSI
> > > +
> > > +maintainers:
> > > +  - Paulo Pavacic <pavacic.p@gmail.com>
> > > +
> > > +description: |
> > > +  Fannal C3004 is a 480x800 panel which requires DSI DCS
> > > +  initialization sequences.
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - const: fannal,c3004
> > > +
> > > +  reg: true
> >
> > Are there no restrictions on the number of reg entries?
> 
> What do you mean by this? May I have some example if possible?

I was commenting on the lack of minItems and/or maxItems.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]